Repository navigation
Conversation
sarawone
added
📅 Sprint 2
cjyuan
reviewed
Nov 7, 2026
Comment on lines
+20
to
+29
| """ | ||
|
|
||
| dp = [0] * (total+1) | ||
| dp[0] =1 | ||
|
|
||
| for coin in coins: | ||
| for amount in range(coin,total+1): | ||
| dp[amount] += dp[amount-coin] | ||
| return dp[total] | ||
|
|
There was a problem hiding this comment.
The code on lines 22-28 implements a totally different approach. While this approach is more efficient, implementing it beats the purpose of the exercise -- identify and caching reusable computed values in an implementation and reuse them.
Could you improve the original code instead?
Comment on lines
+1
to
+7
| def fibonacci(n,memo = {}): | ||
| if n in memo: | ||
| return memo[n] | ||
| if n <= 2: | ||
| return 1 | ||
| memo[n]=fibonacci(n - 1,memo) + fibonacci(n - 2,memo) | ||
| return memo[n] |
There was a problem hiding this comment.
The spacing around parameters/arguments, and around operators are not consistent. Could you use a formatter to keep the format consistent?
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1182
Changelist
Hi,
Thanks for your time reviewing & providing feedback for this PR.
Thanks and Regards,
AYK