Repository navigation
Cape Town | 26-ITP-Sep | Lamla Kamana | Sprint 3 | Coursework/sprint 3 - #1615
lamlakamana-oss wants to merge 25 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi Lamla, thanks for submitting this. Before the code feedback, a note on the PR itself. PR title PR description Example: Change listYou can edit the title and description at any time from the PR page. |
This reverts commit 6bc1c9c.
|
Thanks for working through these exercises. I think there are still two important issues to fix before this is ready to merge: • In Sprint-3/1-key-errors/0.js, the function parameter str is redeclared with let str inside the same scope: • function capitalise(str) { let str = ... } • This is a SyntaxError and the code is still broken. • In Sprint-3/1-key-errors/1.js, the same pattern happens with decimalNumber: • function convertToPercentage(decimalNumber) { const decimalNumber = ... } • This also causes a redeclaration error. These files are meant to demonstrate the bug and the fix, so the corrected version should no longer contain the original error. Please rename the inner variables (for example, result / percentage) so the functions work correctly. I’d suggest fixing those two files and then rechecking the PR. |
|
Renamed the inner variables in 0.js and 1.js. Both files now run without errors. |
cjyuan
left a comment
There was a problem hiding this comment.
Changes look good. I will mark this PR as complete first.
Your PR description is not yet formatted correctly.
Could you reformat it to match the formatting used in this PR?#1618
In particular your PR description is missing a "Changelist" heading, and the checkboxes are incorrectly formatted.
Incorrect syntax
- [x ] I have tested my changes
produces
- [x ] I have tested my changes
Correct syntax
- [x] I have tested my changes
produces
- I have tested my changes

Self checklist
Task Code
CYF-1053
Completed all mandatory and stretch tasks for Sprint 3.
Fixed bugs in the debugging exercises.
Implemented the toPounds function.
Added edge case tests for the time format exercise.
I agree to follow the code of conduct for this organisation