Repository navigation
London | 26-ITP-Sep | Mahir Shah | Sprint 3 | Refactoring Dead Code - #1704
Open
MahirShah300 wants to merge 3 commits into
Open
MahirShah300 wants to merge 3 commits into
MahirShah300 wants to merge 3 commits into
Conversation
MahirShah300
added
the
Needs Review
webmonch
self-requested a review
October 20, 2026 21:43
webmonch
added
Review in progress
webmonch
reviewed
Oct 20, 2026
|
|
||
| function sayHello(greeting, name) { | ||
| const greetingStr = greeting + ", " + name + "!"; | ||
| return `${greeting}, ${name}!`; |
There was a problem hiding this comment.
Did you manage to run this file after your changes?
Author
There was a problem hiding this comment.
Fixed it by making Aman a string
webmonch
reviewed
Oct 20, 2026
| function sayHello(greeting, name) { | ||
| const greetingStr = greeting + ", " + name + "!"; | ||
| return `${greeting}, ${name}!`; | ||
| console.log(greetingStr); |
There was a problem hiding this comment.
Nice! Good catch that this won't run after return.
|
Good job! You identified all of the dead code in both exercises, and exercise 2 is spot on. Worth having another look at exercise 1 to make sure all good there. |
webmonch
added
Reviewed
MahirShah300
added
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1066
Changelist
Removed unused and unneeded code.