[Monsur0001]

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Task code

CYF-1197

Changelist

I suggested edge cases and fixed the code to make sure the test cases pass

[hackertainment]

The code generally looks ok to me. Just need to fix the missing test case. Thank you, and keep it up.

[hackertainment]

While this produces a correct result, it would be a best practice to assign the same type of data to a variable (rather than leaving it to the JavaScript interpreter for type conversion), i.e. ? `0${convertedHours}` : `convertedHours`; so that both values are of the string type.

[hackertainment]

The test cases you have included are:

• 00:00 midnight
• 12:00 noon
• 01:30 single digit hour in the morning
• 13:45 single digit hour in the afternoon
• 23:00 double digits hour in the afternoon

It seems that there is still one case missing. Please add it back, thanks a lot.

[Monsur0001]

Thank you for taking your time to review my code, I have added the "double-digit hour in the afternoon" test case.

[hackertainment]

Good try, but please read the list of test cases carefully. Since you already have both single-digit and double-digit hour in the afternoon in your original tests, the one you have missed would not be in the afternoon anyway.

[hackertainment]

Please refer to my new comment #1725 (comment) , thank you.