Repository navigation
Manchester | 26-ITP-SEP | Monsur Abdulrahman | Sprint 2 | Implement-and-rewrite-tests - #1732
Open
Monsur0001 wants to merge 10 commits into
Open
Monsur0001 wants to merge 10 commits into
Monsur0001 wants to merge 10 commits into
Conversation
…getCardValue function
Monsur0001
added
📅 Sprint 2
cjyuan
reviewed
Oct 23, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
-
Could you use a formatter to keep the code consistently format?
-
Code looks good. Well done.
-
You missed implement the Jest tests in
rewrite-tests-with-jest.
Comment on lines
+29
to
+37
| test("Classifies reflex angles", () => { | ||
| const reflex = getAngleType(270); | ||
| assert.equal(reflex, "Reflex angle"); | ||
| }); | ||
|
|
||
| test("Handles invalid angles (negative)", () => { | ||
| const invalidNegative = getAngleType(-30); | ||
| assert.equal(invalidNegative, "Invalid angle"); | ||
| }); No newline at end of file |
Contributor
There was a problem hiding this comment.
Why not test the boundary cases?
Also, you could consider testing multiple values, including boundary cases, within each category.
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Task code
CYF-1059
Changelist
Implemented and rewrote test cases