Repository navigation
Conversation
|
BigSpaceships
requested changes
Oct 1, 2026
BigSpaceships
left a comment
Contributor
There was a problem hiding this comment.
this is great, just formatting things (i gave up, i'd check all the indentations)
Contributor
|
btw you should update the branch |
…/develop merge develop into bootstrap 5
…/env-setup Updates to config section
* automigrate * remove trailing space
…/bootstrap-5 Bootstrap 5
…ditional into major-form-cache
BigSpaceships
force-pushed
the
develop
branch
from
October 19, 2026 14:07
e3d191f to
18ea5d3
Compare
NickJ-7010
requested changes
Oct 19, 2026
NickJ-7010
left a comment
Contributor
There was a problem hiding this comment.
I have two additional comments:
- The skills get added to the real skill list but also to another list above it. When you click to remove the skill from the real list it doesn't delete nor does it properly restore on refresh. Items that are present in the real list are duplicated upon reload on the other list which represents the localStorage state.
- You should add debounce functionality so that it doesn't try to recompute the localStorage on every keypress but possibly after a second or two, should be easy to do with a setTimeout and clearTimeout
Comment on lines
+66
to
+67
| addSkill(skill) { | ||
| let input = document.getElementById("skill-input") |
Contributor
There was a problem hiding this comment.
Suggested change
| addSkill(skill) { | |
| let input = document.getElementById("skill-input") | |
| addSkill(skill) { | |
| if (skill === "") | |
| return; | |
| let input = document.getElementById("skill-input"); |
This removes errors / duplicate event handlers that happen when you click on the skills field without typing anything. Errors occur when there are no skills in the list and duplicate event handlers get added to the last skill element in the list
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This adds caching to the Major Project Form to save form input, in case the website happens to reload
Why
I was assigned to #598, which wants to fix this
Test Plan
I manually checked by hosting conditional on my personal computer
Env Vars
I did not touch any environment variables
Documentation
The documentation was not updated
Checklist