Repository navigation
Add preference to choose snapshot restore policy: sync or async - #3997
Merged
Merged
Conversation
|
Member
|
While this is not ideal...this is a good short term fix while we address the deeper jca write synchronization issues. We will also be create more test cases to better understand the cause of the deadlock |
shroffk
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Restoring a snapshot over channel access may trigger deadlocks in the JCA lib when writing in a asynchronous/threaded manner. Performing the write operations synchronously seems to be a workaround.
This PR adds a preference
org.phoebus.saveandrestore.util/restorePolicy=<ASYNCHRONOUS|SYNCHRONOUS>controlling the restore execution. Default isASYNCHRONOUS.Testing:
Documentation: