Repository navigation
feat: Add missing provides mapping to Dependency to comply with CycloneDX 1.6 spec - #599
Conversation
c05258b to
d42bf3b
Compare
d42bf3b to
62a4ffc
Compare
a358c91 to
4e13d3a
Compare
|
@mr-zepol Hi, apologies for the very late reply, pushed some fixes after your review, thanks! |
|
@mr-zepol Hi! Is there anything else I can do here? Would it be possible to have another review? Thanks! |
|
@mr-zepol / @nscuro / @stevespringett can you get back to this please? |
|
I don't see any remaining issues. @vibe13, can you resolve the merge conflicts please? |
…neDX 1.6 spec Signed-off-by: Andrea Vibelli <avibelli@redhat.com>
Signed-off-by: Andrea Vibelli <avibelli@redhat.com>
…alizer - Replace broken writeXMLProvides (used writeFieldName+writeStartArray causing 'Can not write a field name, expecting a value') with the same processNamespace pattern used for sub-dependency elements - Extend the writeStartArray/writeEndArray guard in writeXMLDependency to cover provides children, not only sub-dependency children; without this, a dependency with only provides (no sub-deps) would fail with 'Can not start an object, expecting field name' - Replace CollectionUtils.isNotEmpty() calls (removed upstream dependency) with inline null+isEmpty checks Signed-off-by: Andrea Vibelli <avibelli@redhat.com>
4e13d3a to
d76cbb2
Compare
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 13 |
🟢 Coverage 80.65% diff coverage · +0.01% coverage variation
Metric Results Coverage variation ✅ +0.01% coverage variation Diff coverage ✅ 80.65% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (cf5d168) 7831 5861 74.84% Head commit (d76cbb2) 7859 (+28) 5883 (+22) 74.86% (+0.01%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#599) 31 25 80.65% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
|
thanks! |
4 participants
Following #565, this PR attempts to add the missing mapping to comply with the CycloneDX 1.6 spec for the "provides" field inside the Dependency object: https://cyclonedx.org/docs/1.6/json/#dependencies_items_provides.