Repository navigation
test(qa): rewrite the Linux LibreOffice fidelity baseline from the CI runs of #897 and #899 - #898
Merged
Merged
Conversation
… run of #897 Since d85aa59 a list item's exact lines are settled with the page, and a cell's end settles what its lines carry. The Linux baseline still held the 40 documents it moves there as they stood before. Their rows are taken from CI run 38551609338 on that change; with them the baseline is that run's measurement byte for byte.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Both of these were merged with their Word and Windows LibreOffice baselines rewritten, and their Linux LibreOffice baseline left to follow from their CI runs:
Until then the Linux baseline holds the documents they move as they stood before, so a change that undid either would pass the DOCX fidelity job on Linux.
What changed
libreoffice-linux.tsvandlibreoffice-linux-lines.tsvnow match thedocx-fidelityartifact of #899's last CI run (38571103664) byte for byte, summary and lines. That run measured2.5-devwith #897 merged, and its first run (38564227066) measured the same.#897: the rows of the 40 documents it moves on Linux. All of them are among the 48 whose DOCX it changes. They are taken from the artifact of #897's last CI run (38551609338), which its first run (38550387636) measured byte for byte.
Lines that moved by more than 0.05pt: 625 nearer the page, 303 further from it.
Medians of the 38 documents whose summary row changes: 17 nearer, 17 further, 4 the same. Their sum falls by 0.24pt.
cv-panelcv-terracotta_railcv-serif_headlineinvoice-consultingletter-panelinvoice-obsidiancv-violet_gridFurther documents.
invoice-obsidianandcv-violet_gridstand further from the page here, as they do in Word and Windows LibreOffice. Their lines already stood high, and the settled tenth of a point moves them a step further.Lines past 2pt.
invoice-merchant's go from 12 to 5, and it passes.invoice-payments' go from 45 to 40.Acceptance goes from 52 to 53 of 62 documents.
#899: the rows of the five documents it moves. These are
cv-orange_ops,cv-serif_headline,invoice-workspace,proposal-editorialandproposal-northline, the same five whose DOCX it changes.Lines that moved by more than 0.05pt: 46 nearer the page, 2 further. The two further are lines of
cv-orange_ops, each by 0.05pt.90th percentiles:
proposal-editorialproposal-northlinecv-serif_headlineproposal-northline's median goes from 0.17 to 0.13pt.Acceptance stays at 53 of 62.
Verification
./mvnw -B -ntp test -f qa/pom.xml→ BUILD SUCCESS, 1820 tests.DOCX Fidelity (LibreOffice)job holds2.5-dev's export to the new baseline.Lane: test — qa fidelity baseline only.