Repository navigation
Entry의 View 구성 요소와 렌더링 입력을 분리한다 - #941
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🎯 의도
MainView.swift의 뷰 생성 함수를 같은 파일의private structView로 분리📝 작업 내용
📌 요약
MainView의tabContent(_:)와tabView(_:isSelected:)를MainTabContent로 분리SideBar의tabButton(_:)을SideBarButton으로 분리🔍 상세
MainTabContenttab,isSelected,showsSideBar,windowEventisTabContentActive환경 값과 tab bar 가시성 적용 순서 유지SideBarButtontab,isSelected,unreadPushCount,actionStoreOf,selectedTabBinding, 저장 클로저 전달 없음SideBar,ResizableSideBarModifier의 같은 파일 전용 접근 수준과 동작 유지TabView(selection:)와 네 개Tab의 구조적 위치 유지📸 영상 / 이미지 (Optional)
Instruments 측정 (View Body)
View Body (Legacy), 변경 전후 각 5회 교차 측정 후 중앙값 비교, 괄호는 5회 측정 범위홈→오늘→알림→프로필→홈탭 전환 10바퀴(탭 40회)MainViewMainViewMainTabContentMainViewbody 평가 시간은 감소했으나 같은 규모의 평가가MainTabContent로 이동해 합계는 측정 범위가 겹침SideBarButton은 폰 크기의 시뮬레이터에서 사이드바가 표시되지 않아 측정 대상에서 제외