Repository navigation
Remove Dockerfile and image build workflow - #325
Merged
Merged
Conversation
Nothing is known to use the ghcr.io image, and it has failed to build since requires-python was raised to >=3.12 in #307.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
=======================================
Coverage 81.35% 81.35%
=======================================
Files 31 31
Lines 5755 5755
Branches 332 332
=======================================
Hits 4682 4682
Misses 995 995
Partials 78 78 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Docker image build has failed since #307 raised
requires-pythonto>=3.12, because the base image was stillpython:3.11-slim. That includes thev1.6.0tag. Nothing is known to useghcr.io/diamondlightsource/python-zocalo, and a code search of the org finds no references to it, so this removes the Dockerfile and the build workflow instead of fixing them.Images already published to GHCR are left as they are.