Repository navigation
Merge next into feat/kms-epochs-combined - #1562
Merged
Merged
Conversation
The job used the runner image's system Python. On ubuntu-26.04 that is 3.14, for which the locked pydantic-core 2.33.2 has no wheel, and its source build fails because PyO3 0.24 supports at most 3.13. Signed-off-by: Kevin Wang <wy721@qq.com>
ci(sdk): pin Python 3.13 for SDK tests
prepare_mr_config_v3() rewrites .instance_info on every launch with a truncating fs::write. A failed write or power loss leaves the file empty, losing instance_id_seed and with it the instance ID that keys the VM's persistent disk. Use safe_write, as the guest-reported instance info path already does. Signed-off-by: Kevin Wang <wy721@qq.com>
* ci: run checks on PRs to feat/** and test vmm UI and vmm-cli PRs targeting feature branches only got the Foundry checks. Also fail the Rust job when cryptsetup is missing so the LUKS tests cannot silently skip. Signed-off-by: Kevin Wang <wy721@qq.com> * ci: check auth-eth-bun on feature branch PRs and fix the vmm-cli deps cryptography 50.0.0 needs cffi 2.0.0 or later, so requirements.txt could not be installed with cffi pinned to 1.17.1. The file exists on every branch, so install it unconditionally. Signed-off-by: Kevin Wang <wy721@qq.com> --------- Signed-off-by: Kevin Wang <wy721@qq.com>
* docs(kms): require admin TLS for onboarding handover Admin.GetKmsKey needs the caller's RA-TLS certificate, which a plain-HTTP admin listener cannot receive: without [core.admin.tls] the call fails with "No attestation provided" and the onboarding client fails to verify the source. Document the source-side admin setup (TLS, a reachable address, the token), fix the onboarding example's port (8001, not the gateway's 9202), and use https in the README admin example that already configures TLS. Signed-off-by: Kevin Wang <wy721@qq.com> * docs(kms): note that admin TLS needs no mutual section Signed-off-by: Kevin Wang <wy721@qq.com> --------- Signed-off-by: Kevin Wang <wy721@qq.com>
…ochs Signed-off-by: Kevin Wang <wy721@qq.com> # Conflicts: # .github/workflows/sdk.yaml # docs/deployment.md # dstack/kms/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync
next(including #1558 and #1559) so PRs into this branch run the Rust, SDK, auth-eth, prek and spdx checks.Conflicts resolved:
sdk.yaml: keep next's Python 3.13 setup step.docs/deployment.md,dstack/kms/README.md: keep this branch'spublic_key_handoverdefault-off wording and add docs(kms): require admin TLS for onboarding handover #1558's admin TLS requirements.The
feat/**trigger fromkms-auth-eth-bun.ymlcarried over to the renamedkms-auth-eth.yml.