Repository navigation
fix(gateway): keep an IP allocated while another instance holds it - #1605
Merged
Merged
Conversation
kvinwang
enabled auto-merge
November 18, 2026 08:46
Signed-off-by: Kevin Wang <wy721@qq.com>
kvinwang
force-pushed
the
fix/gateway-forget-shared-ip
branch
from
November 18, 2026 10:13
a024e3c to
fc1405c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two live instances can share an IP while a local registration that lost an IP conflict is kept through its grace period, or while a record is unreadable. Removing one of them (
remove_cvm, recycle) freed the address unconditionally, so the next registration was handed the IP the other still used.ProxyState::release_ipfrees an address only if no other instance holds it; used inforget_instance, the reload's IP-change branch and the rebuild path of registration.Found by the Lean model of allocation (#1597,
IpAlloc.lean,forget_shared_ip_reissues_live_ip).