Skip to content

fix(gateway): keep an IP allocated while another instance holds it - #1605

Merged
kvinwang merged 1 commit into
nextfrom
fix/gateway-forget-shared-ip
Nov 18, 2026
Merged

kvinwang merged 1 commit into
nextfrom
fix/gateway-forget-shared-ip

Conversation

@kvinwang

Copy link
Copy Markdown
Collaborator

Two live instances can share an IP while a local registration that lost an IP conflict is kept through its grace period, or while a record is unreadable. Removing one of them (remove_cvm, recycle) freed the address unconditionally, so the next registration was handed the IP the other still used.

ProxyState::release_ip frees an address only if no other instance holds it; used in forget_instance, the reload's IP-change branch and the rebuild path of registration.

Found by the Lean model of allocation (#1597, IpAlloc.lean, forget_shared_ip_reissues_live_ip).

@kvinwang
kvinwang enabled auto-merge November 18, 2026 08:46
@kvinwang
kvinwang force-pushed the fix/gateway-forget-shared-ip branch from a024e3c to fc1405c Compare November 18, 2026 10:13
@kvinwang
kvinwang merged commit 089dad4 into next Nov 18, 2026
21 checks passed
@kvinwang
kvinwang deleted the fix/gateway-forget-shared-ip branch November 18, 2026 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant