Repository navigation
v26.12rc1 - #9740
v26.12rc1#9740
Conversation
Andezion
left a comment
There was a problem hiding this comment.
the maxhops entry duplicates an earlier point release at CHANGELOG.md line 14. The #9627 commits ("askrene: getroutes: add maxhops option", "xpay: call askrene with maxhops", and others) are already in v26.06.10. The 26.06.10 section already says "xpay: Clamp the length of the payment routes using askrene's maxhops option. . ." (line 173). Checklist step 4 says to remove entries that were in earlier point releases. Users on 26.06.10 already have this parameter. So maybe drop line 14. If you want to keep it as a 26.12 highlight, add a note that it was backported to 26.06.10? Also the #8557 splice crash fix is under EXPERIMENTAL at CHANGELOG.md line 101, the commit says Changelog-EXPERIMENTAL, but splicing has been on by default since 26.04 ("Protocol: Splicing is enabled by default", #9021). --experimental-splicing is now a no op (lightningd/options.c at line 1279). Users who skip the EXPERIMENTAL section will miss a crash fix that affects default nodes. Sp maybe do ### Fixed, for example - splicing: fixed crash when splicing a channel which hasn't been announced yet ([#8557])
and v26.06rc1 used the same placeholder as v26.12rc1, is this ok?
|
We still have the db migration problem i think: |
|
I believe this fix is better than reordering the migrations to not mess with people running master. |
Agreed, creating the tables if they're missing is better than renumbering. The definitions match 283/284, the copy into them already ignores existing rows, and the repeated feerate clamps are idempotent. Let's get it in before RC1. |
Thanks, both fixed. |
49c827c to
1f7a91e
Compare
1f7a91e to
97a900a
Compare
jaonoctus
left a comment
There was a problem hiding this comment.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
tACK 97a900add7257f74a9c11c95ac165a31a30d94bd
Built with gmake on macOS arm64 (--disable-rust) and tested the database
migration up and down against a real v26.06.10 build on regtest (sqlite3).
v26.06.10 creates the wallet: db version 284, no our_outputs/our_txs.
Up: this commit upgrades it from 284 to 292, creates both tables and adds
payments.failmsg. listfunds is identical before and after, and a new
deposit and a withdraw work afterwards.
Down: tools/lightning-downgrade takes it from 292 to 282 and drops the new
tables and column. v26.06.10 starts on it again (282 to 284) with all
outputs intact.
Up again: from 284 to 292, same listfunds.
No BROKEN log lines in any run. run-migrate_backfill_bwatch_tables and
run-db pass.
Limits: wallet outputs only (no channels, payments or forwards in the db),
and the untagged build needed --database-upgrade=true.
-----BEGIN PGP SIGNATURE-----
iKsEARYKAFMWIQQTBU9gvuuH0rnH1336/g1mZVR61gUCavyeVBsUgAAAAAAEAA5t
YW51MiwyLjUrMS4xMiwwLDMZHGphb25vY3R1c0Bwcm90b25tYWlsLmNvbQAKCRD6
/g1mZVR61utuAQDwV7xrdkVXEU6NYRgWBTsHEwtFs/L5Ij58gJdyxrkP2wD+OAMJ
om/nyacq/Z2zw/F/9l9RWP0pFUphkGkC43lgygg=
=rLoT
-----END PGP SIGNATURE-----
Changelog and package versions for v26.12rc1.
Changelog-None
🤖 Generated with Claude Code