Repository navigation
Fix cross-region block access and replaced block checks - #2321
Merged
Merged
Conversation
me4502
requested changes
Nov 1, 2026
me4502
requested changes
Nov 2, 2026
Contributor
Author
|
Thanks for the feedback. I've reverted the unnecessary listener changes and removed the Javadoc. getFirstBlock() now skips blocks outside the current Folia region and continues looking for the next accessible block. |
me4502
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid reading a causing block from a region that is not owned by the current Folia thread. This prevents thread violations when a falling block lands in a different region or world from its origin.
Apply the same ownership check to block placement, block breaking, and fire cause checks. When the causing block cannot be read, its material-specific flags cannot be evaluated.
Also fix the replaced-block check in
BlockPlaceEvent, which previously compared the replaced material with itself and never fired a break event.Error log for reference:
https://pastes.dev/UWDTIF5k26