Repository navigation
fix: complete V3 execution isolation and release candidate validation - #328
EvanProgramming wants to merge 220 commits into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1fd3f270ef
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| data = receipt.tool_result.data if receipt.tool_result is not None else None | ||
| if (isinstance(data, dict) and isinstance(data.get("content"), str) | ||
| and data.get("truncated") is False): | ||
| read_content = data["content"] | ||
| else: | ||
| criterion_status = "unavailable" |
There was a problem hiding this comment.
Preserve complete read evidence before archiving tool output
When a successful read_file result exceeds the 12,000-character serialized-output threshold, _make_execution_receipt replaces its data with an artifact reference before this check runs. Consequently, even a complete read with a matching acceptance predicate lacks content and truncated here and is marked unavailable. For example, a roughly 7 KB file containing the required text cannot satisfy its Working Plan read criterion, and reading the artifact cannot satisfy the original read_file contract either. Retain the trusted complete content for predicate evaluation separately from the bounded provider/journal representation.
Useful? React with 👍 / 👎.
| if sum(handle.process.poll() is None for handle in self._handles.values()) >= 32: | ||
| raise RuntimeError("session process handle limit reached") |
There was a problem hiding this comment.
Bound retained handles when allowing completed-process replacement
In a long-lived session that repeatedly launches background commands, counting only running processes removes the previous bound on retained handles: every completed handle remains in _handles, and neither completion nor close() evicts it. Each handle retains up to one million characters from each output stream, so sequential commands can now grow session memory without limit despite never approaching 32 concurrent processes. An isolated run confirmed that 40 completed commands leave 40 retained handles and zero active processes. Add bounded retention or eviction for completed handles alongside the concurrent-process limit.
Useful? React with 👍 / 👎.
V3 release candidate
The signed candidate is
ebe7173d86d15fef133bfb508c16532541e12e05. The obsolete-assumption check compares the test target and fixture workspace, with a narrow allowance for standard unittest output options. It rejects changed targets, test selectors, other working directories, environment overrides and additional commands. Verification still requires the original failing receipt, cancellation of the seeded task in sequence and a passing receipt bound to the completed replacement task.Independent replay accepted the two recorded complete sequences and rejected the recording with premature cancellation. The benchmark also retains payload-free source locations for provider contract failures. Those diagnostics leave failure decisions unchanged.
Validation