Repository navigation
feat(recall): name a required skill that follows a branch - #108
Conversation
A Gene may now name a skill as skill:git+https://<repo>@<branch>#path=<dir>. Accept it with the same rules Evolver applies (a commit still needs sha256, a branch takes none, branch names that git could misread are refused) and stop calling such a skill pinned in the injected text. Fixes EvoMap#107
|
Sentinel 已审核此变更,未发现已核验问题,但发现需要人工确认的风险。 另有 1 个需要人工确认的风险;黄色 advisory 不阻塞合并,建议开发 agent review advisory 评论并逐条确认。 开发 agent 查询详情: 调用 MCP 工具 由 Sentinel 审核 · 目标提交 e016660dd689 |
|
Sentinel 保留了 1 个尚未确认的审核候选。这些黄色条目不阻塞合并;红色 P0/P1 与其他独立硬门禁不受影响。 单一猜测、缺少变更行证据或纯 checklist 的候选会统一降为 P3。
需要完整证据时,可用行末 由 Sentinel 审核 · 目标提交 e016660dd689 |
…t key Evolver refuses a skill:git+ fragment key other than sha256 and path, so the plugin would hand the model an install command that fails. Refuse the same references for both pinned and branch forms.
|
回复 Sentinel 对 e016660 的意见: P2 分支引用接受未知 fragment 参数(
|
|
Sentinel 已审核此变更,未发现需要报告的问题。 开发 agent 查询详情: 调用 MCP 工具 由 Sentinel 审核 · 目标提交 b5290cc167c5 |
|
回复 Sentinel 对 b5290cc 的复审(https://github.com/EvoMap/evolver-agent-plugin/pull/108#issuecomment-7062149070): 复审没有新的审核意见,本 PR 的机器人意见已全部闭合。
无需后续 PR 或 issue。 |
Fixes #107
Problem
The plugin names a Gene's required skill only when it pins a full commit and a
sha256digest. Evolver is adding a reference that follows a branch (EvoMap/evolver-v2-private-dev#1624), so a skill can change without republishing the Gene:lib/required-skills.jsreturnednullfor any entry withoutsha256, so a Gene written this way got no install instruction.Change
lib/required-skills.jsaccepts@<branch>#path=<dir>under the rules Evolver applies: a full commit still needssha256, a branch takes none, and a branch name allows only letters, digits,.,_,-,/(no.., no empty, dot-led or.locksegment, no leading-). Anything else still names no skill, as before. A fragment key other thansha256andpathalso names no skill, for both forms, because Evolver rejects it (b5290cc, from Sentinel's advisory).How a Gene is written after release
Once Evolver with EvoMap/evolver-v2-private-dev#1624 and this plugin are both released, a Gene can name the demo skill as:
Both releases need someone with npm / plugin release rights. A Gene in this form is rejected by Evolver 2.0.54 (
skill fetchreports the reference as invalid), so release Evolver first, or together with the plugin.Verified
main(requiredSkillLinesOfreturned no lines).node --test test/required-skills.test.js: 11 pass, including 2 new cases: a branch reference next to a pinned one, and the rejected shapes (branch with a digest, commit without one, an unknown fragment key,--upload-pack=x,main/../../tags/v1).npm test: 1227 tests, 1214 pass, 10 skipped, 3 fail. The 3 failures are intest/runtime/desktop-engine.test.js. They fail the same way with this change stashed, and feat(recall): name the skill a recalled Gene pins, with the command that installs it #106 reported the same 3 onmainon this machine.@main#path=skills/quest-prototype-three-round-gateresolved to48f06952654a270e04f217e5683a8e667d5db29b(matchesgit ls-remote refs/heads/main), and the installed content digest matched an independentshasumof the directory.