Repository navigation
fix(version): accept firebase 13 in peer range - #156
Merged
Merged
Conversation
Contributor
|
I believe this package must drop support of firebase v9 before widening it. EDIT: Looks like several firebase packages were updated at firebase/firebase-js-sdk#10314, by changing the minimal supported NodeJS version from And therefore most packages with this update were shipped at Firebase JS SDK v13 per https://github.com/firebase/firebase-js-sdk/releases/tag/firebase%4013.0.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Widen
peerDependencies.firebaseto include^13.0.0, following the same pattern as #76 (v10), #117 (v11), and #152 (v12).What changed
package.json:"firebase": "^9.0.0 || ^10.0.0 || ^11.0.0 || ^12.0.0"->"^9.0.0 || ^10.0.0 || ^11.0.0 || ^12.0.0 || ^13.0.0"Context
reactfirein chore(deps): update firebase to v13 reactfire#841) addingfirebase@^13.0.0support otherwise emitnpm warn ERESOLVE overriding peer dependency(or fail under--strict-peer-deps) untilrxfire's peer range includes^13.0.0..github/workflows/test.yml:firebase@13(@firebase/ai@3.0.0) requiresnode >= 24.12.0, whereastest.ymlcurrently runs on Node 20 (20.20.2), sotest.ymlis left untouched here to keep the peer range change minimal.