Repository navigation
feat: Add test case for a flag dependency on a feature with a non-ASCII name - #66
Merged
Merged
Conversation
…II name Flagsmith writes a dependency's condition as `$.flags[<json.dumps(name)>].enabled`, which escapes non-ASCII characters, so a dependency on `été` reads `$.flags["\u00e9t\u00e9"].enabled`. Engines that look the escaped name up verbatim never match the dependency's segment.
emyller
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a test case ensuring a dependency on a feature with a non-ASCII name, written as the API writes it, is resolved.
How did you test this code?
Each implementation was run against its pinned test data with this case added:
mainmainmainmainmainmainmainThe three failures are identical:
dependentkeeps its default with reasonDEFAULT, and no segment matches.Contributes to SDK-6
Review effort: 1/5