Skip to content

feat: Support getExperimentFlag, trackEvent and trackExposure methods - #322

Closed
flagsmithsmith[bot] wants to merge 4 commits into
mainfrom
openhands/sdk-spec-v0.7.1
Closed

flagsmithsmith[bot] wants to merge 4 commits into
mainfrom
openhands/sdk-spec-v0.7.1

Conversation

@flagsmithsmith

@flagsmithsmith flagsmithsmith Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Contributes to Flagsmith/sdk-spec#13

renovate Bot and others added 2 commits November 5, 2026 17:35
Its entry in Flagsmith/sdk-spec's compatibility matrix at v0.7.1: `core or events or local-evaluation`.
@flagsmithsmith flagsmithsmith Bot added the sdk-spec Bumps of the Flagsmith SDK behavioural spec label Nov 5, 2026
@coderabbitai

coderabbitai Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 2186b219-e54a-462d-827c-26befaa5cec4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@codspeed

codspeed Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 15 untouched benchmarks


Comparing openhands/sdk-spec-v0.7.1 (d8e4216) with main (ee89f5a)

Open in CodSpeed

flagsmithsmith Bot and others added 2 commits November 5, 2026 20:10
…c v0.6.0

Spec v0.6.0 adds @events scenarios for getExperimentFlag, trackEvent and
trackExposureEvent, plus a "Create the SDK client with events enabled" step.
The SDK has supported these since 9.1.0, so the steps call the existing
public API.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 6a108ea)
The getExperimentFlag step returned the feature name it was asked for,
so the spec could not tell whether the SDK resolved the right flag.
Report the evaluated flag's featureName instead.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@flagsmithsmith

flagsmithsmith Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor Author

The spec job was failing because spec v0.6.0+ added @events scenarios for getExperimentFlag, trackEvent and trackExposureEvent, plus a Create the SDK client with events enabled step, and this SDK's steps file didn't wire them (SDK implements 4/8 steps). The SDK has supported all three since 9.1.0, so no library change is needed. The fix is to wire the missing steps to the existing public API.

Changes

  • Re-applied 1f669f4 (wire experiment flag and event tracking steps). It conflicted with the Create the SDK client with local evaluation step added since; both factories are kept.
  • The experiment flag step now reports the evaluated flag's own featureName instead of the name it was asked for, so the spec checks what the SDK resolved.

I ran spec v0.7.1 locally with core or events or local-evaluation against the image built from this branch. All 9 scenarios pass, and all 8 steps are implemented. Lint and the full unit suite pass (475 tests).

Review effort: 1/5

🤖 Generated with Claude Code

@flagsmithsmith
flagsmithsmith Bot marked this pull request as ready for review November 5, 2026 20:32
@flagsmithsmith
flagsmithsmith Bot requested a review from a team as a code owner November 5, 2026 20:32
@flagsmithsmith
flagsmithsmith Bot requested review from emyller and removed request for a team November 5, 2026 20:32
@flagsmithsmith flagsmithsmith Bot changed the title feat: Implement SDK spec v0.7.1 feat: Support getExperimentFlag, trackEvent and trackExposure methods Nov 6, 2026
@flagsmithsmith

Copy link
Copy Markdown
Contributor Author

Superseded by #324, which carries this pull request's work over to the SDK spec's latest version.

@flagsmithsmith flagsmithsmith Bot closed this Nov 11, 2026
@flagsmithsmith
flagsmithsmith Bot deleted the openhands/sdk-spec-v0.7.1 branch November 11, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sdk-spec Bumps of the Flagsmith SDK behavioural spec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant