Repository navigation
README: say what omx-clap-host answers for param_info and presets today (#153) - #219
Merged
Merged
Conversation
…ay (#153) param_info is answered from org.openmixer.param-contract/1, with -511 only for a parameter the worker holds no checked contract for; preset_list and preset_get list a CLAP plugin presets. The LV2 param_info sentence (-511 until the daemon reads the bundle port data, #152) is unchanged. tests/readme_facts.py, run by make test, fails on the old sentences. (cherry picked from commit 2668b18)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #153
Rewrites the two stale README sentences (CLAP param_info, omx-clap-host and presets); the LV2 param_info sentence stays.
Proof: tests/readme_facts.py (new make check-readme-facts, part of make test) fails on the old README with 5 findings and passes with the change.
Replaces #216, whose Makefile line conflicted with main after #213 to #215 merged; same commit, cherry-picked onto main with both test targets kept.