Repository navigation
The isolated step plays an instrument a note it can hear - #274
Merged
Merged
Conversation
The tool sent its one note in the first cycle, before the MIDI link existed, so an instrument never heard it and read silent: the live test on the synth fixture reads silent true. The notes now start after the links and each third of the window adds one more, held. The step says how many MIDI inputs it linked, and a silence from the old tool, which does not say, is run again by a pass; one that heard the notes is not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The isolated step refused instruments as silent. On a Raspberry Pi 5 that was 7 of 47: Helm, Kars, Nekobi, obxd, ADLplug, OPNplug and JuceOPL, all
isolated.silent-output.Cause.
isolated_signalsent its only note-on in the first cycle afterjack_activate, before it linked its MIDI port, so the instrument never heard it. The live test used only an effect. The first commit adds a live test on the synth fixture. On CI it reads"added":true,"alive":true,"silent":true, and the effect test in the same run passes.Fix.
midiInputsLinked, and a silent refusal says whether notes were linked.--isolated-onlyruns it again. A plugin that heard the notes and stayed silent is not retried.Threshold and window, unchanged. Silence is a peak under 1e-5 (-100 dBFS), and the window is 3 s. A slow attack should clear -100 dBFS well inside that. A plugin that takes longer than the window to start sounding after
addwould still read silent. That has not been measured on a real patch, so the 7 plugins on the Pi are the check.Not covered. The live test is CLAP only; LV2 instruments such as Helm and Kars have not run the real step except on the Pi.