Repository navigation
tests: the adapter pass plays a real instrument, mda Piano from the distribution - #275
Merged
Merged
Conversation
…istribution A stand-in proves what is done with a level, never that a note reaches an instrument.
… real-instrument test go red
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The adapter pass's held note was tested only with a stand-in, which cannot show that a note reaches an instrument. This runs tools/mod-host-admit.mjs on mda Piano from mda-lv2, under omx-clap-host on a private JACK server, reads its JACK ports with jack_peak, and fails on CI if a tool is missing.
On CI it passes on the real instrument. With the tool's note replaced by a note-off, in a commit reverted here, it went red.