Repository navigation
The held note test plays a wide range of keys - #277
Merged
Merged
Conversation
… and the isolated step
…d the isolated step One key read silent on five drum kits healthy under the adapter. Both now play 30 keys from 36, each held, and read from before the first, so a mapped key and a short hit both count. A silent-under-note from one key is run again by --adapter-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A held note on one key read silent on five avldrums kits that are healthy under the adapter: by hand, 30 notes from key 36 gave them +6.4 and +4.3 dB. Which of a missing mapped drum or a hit decayed before the window explains each is not proven.
silent-under-notefrom one key has nonotesfigure, so--adapter-onlyruns it again. One from the wide range is not rerun.Red first. A drum fixture in both formats answers only keys 36 to 40 with a 20 ms hit. In the first commits its live tests fail on CI under both the adapter pass and the isolated step.
Not changed. Six other plugins are silent under jalv too (lsp sampler_stereo, miniopl3, drmr, fabla, calf Fluidsynth, jv880), so
unknownstays right for them. 30 held keys is more load than one, and that has not been measured on the Pi.