Repository navigation
chore: sync with upstream/main (2ebe7f8e2) - #92
Merged
Merged
Conversation
…not the repository (pingdotgg#37638)
…oaded" (pingdotgg#37651) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…otgg#37632) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…he id (pingdotgg#37493) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…otgg#37150) Co-authored-by: Simone <185146821+Lucenx9@users.noreply.github.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…otgg#37661) Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
… keep uploading (pingdotgg#37681) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…gdotgg#37703) Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: screen <screen@users.noreply.git.cafe> Co-authored-by: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ead (pingdotgg#37735) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…s as a silent success (pingdotgg#37738)
…ingdotgg#37733) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ingdotgg#37741) Co-authored-by: Usama Khan <usama@Usamas-MacBook-Pro.local> Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
…heir project (pingdotgg#37682) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
pingdotgg#38250) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ingdotgg#38276) Co-authored-by: Grok 4.7 <noreply@x.ai> Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Grok 4.7 <noreply@x.ai> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…n recovery (pingdotgg#38241) Co-authored-by: Grok 4.7 <noreply@x.ai> Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ngdotgg#38262) Co-authored-by: Cursor <cursoragent@cursor.com>
…g#38313) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ssing (pingdotgg#38325) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ed attempt (pingdotgg#38334) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…#38315) Co-authored-by: Julius Marminge <julius0216@outlook.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 07ebe64868
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The fork is 253 commits behind
upstream/main. This sync keeps the features recorded indocs/adrand uses upstream's implementation wherever it can.Change
Merged
pingdotgg/t3codemain at2ebe7f8e2. 20 files had conflicts.git show --remerge-diff 07ebe64868shows the whole resolution.Workflows (ADR 0011). Upstream changed four mobile workflows that the fork does not ship, and they are dropped again. Upstream's three new composite actions are dropped too:
drop-checkout-credentials,eas-local-buildandrecord-build-tag. Only those workflows use them.ci.ymltakes upstream's new Linear GraphQL and i18n catalog checks. The version core is now0.1.10, which the ADR records.Implemented upstream. No upstream commit in this range supersedes an ADR, in whole or in part.
Re-homed on upstream's structure
createNewBranch) and leading-command split are re-applied on top. The fork's existing-branch restore test is ported toit.effect.mod+ssplits). Upstream feat(web): unassign default keyboard shortcuts pingdotgg/t3code#28687 lets users unassign a default (when: "false"), and late defaults skip unassigned rules. The fork's loop applies that skip to itsreplacesentries too.t3_thread_launch). Upstream fix(server): t3_thread_launch without a workspace follows the worktree default pingdotgg/t3code#38261 gives a launch with no workspace a worktree from the current branch. The fork keeps that, and still skips thestartFromOriginfill forcreateBranch: false. Agent launches still don't adopt the default base branch. Upstream fix(server): t3_thread_launch refuses an explicit branch that already exists pingdotgg/t3code#31279 refuses an explicit existingbranch; an existing-branch checkout names none, so it is unaffected.parseChangeRequestUrlkeeps the mount's case. Upstream's newparseIssueUrl(feat(issues): add GitLab, Azure DevOps, and Forgejo issue trackers pingdotgg/t3code#19261) is kept as written, and its lower-cased issue scope is recorded as a gap. Upstream's tea 1 MB page cap (fix(server): Forgejo PR lookup reads tea API pages over 1 MB pingdotgg/t3code#38211) sits beside the fork'sSshRemoteLookup.cliInstallCommand;withoutRemoteCredentials;mcpToolListJsonBytesis 53,150, which is upstream's 52,145 plus the fork's 1,005.AgentContextBudget.test.tsmeasures it.runtimeLayer.test.ts,settings.test.tsand the Pi adapter tests.Fixes for new upstream interactions
pullRequestLinkPanelTarget, which no longer took a project, so the fork's line failed typecheck. The helper now takes an optionalprojectId. The thread PR panel's new read-ahead passes the thread's project, so it warms the same project a click opens.git configread hit it, and the fake now answers that read with no configured URL, as the fork's other tests do.ADRs
All ADRs now compare against
2ebe7f8e2. Notes were added in 0002, 0004, 0008, 0009, 0011, 0014, 0016, 0017, 0020 and 0023.Verification
vp run check:changed origin/main:install.shand setup-script tests fail because NixOS has no/bin/bash,mkdirorunameon the sandboxed path.GitVcsDriverandRepositoryIdentityResolverfail because of the host's globalurl.*.insteadOf. They pass withGIT_CONFIG_GLOBAL=/dev/null.GitVcsDriverCore, failed one output-cap line count under full-suite load and passes alone.RelayClientLedgerandserviceProtection. Those files match upstream, and the cases fail for lack of/bin/psandmkdir.source-control-forgejo,source-control-core,shared,contracts,client-runtime,provider-pi.Not run locally:
mcp-tool-useeval;Model: Claude Opus 5.5; harness: Claude Code in T3 Code.
🤖 Generated with Claude Code