Repository navigation
chore: sync with upstream/main (aced664ed) - #94
Merged
Merged
Conversation
…otgg#38329) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ngdotgg#38347) Co-authored-by: Simone <185146821+Lucenx9@users.noreply.github.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…nders before Attach (pingdotgg#38357)
…nger freezes the thread (pingdotgg#38368) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ingdotgg#38377) Co-authored-by: Simone <185146821+Lucenx9@users.noreply.github.com>
…dotgg#38387) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…tgg#38393) Co-authored-by: Simone <185146821+Lucenx9@users.noreply.github.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…eading (pingdotgg#38397) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…gdotgg#38425) Co-authored-by: Grok 4.7 <noreply@x.ai>
…tgg#38431) Co-authored-by: Grok 4.7 <noreply@x.ai> Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…failed (pingdotgg#38423) Co-authored-by: Grok 4.7 <noreply@x.ai> Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…s Chrome, not HeadlessChrome (pingdotgg#38445)
… renders (pingdotgg#38458) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…poser (pingdotgg#38443) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ingdotgg#38451) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
pingdotgg#38980) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…laced (pingdotgg#38978) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…th (pingdotgg#24683) Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ished states (pingdotgg#38986) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ingdotgg#38996) Co-authored-by: DominikScholz <12826585+DominikScholz@users.noreply.github.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ady loaded (pingdotgg#39000) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ails (pingdotgg#38995) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…pingdotgg#38998) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…dotgg#39004) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ch (pingdotgg#39012) Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ngdotgg#39017) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…onnections (pingdotgg#38974) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…pingdotgg#38991) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…gg#39007) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…lost (pingdotgg#39018) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…hived one (pingdotgg#38984) Co-authored-by: Grok 4.7 <noreply@x.ai> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…eUsage (pingdotgg#39024) Co-authored-by: Julius Marminge <julius0216@outlook.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dc1ad38371
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The fork is 226 commits behind
upstream/main. This sync keeps the features recorded indocs/adrand uses upstream's implementation wherever it can.Change
Merged
pingdotgg/t3codemain ataced664ed. 29 files had conflicts.git show --remerge-diff dc1ad38371shows the whole resolution.Workflows (ADR 0011). Upstream changed no workflows in this range. Only
ci-changes.cjs(new shared git test helpers) andVOUCHED.tdcame in under.github.Implemented upstream. No upstream commit in this range supersedes an ADR, in whole or in part.
Translated fork copy (new ADR 0030). Upstream translated the whole app into every supported language (pingdotgg#37893), and most conflicts were upstream's i18n wrapping against fork copy. Each one keeps upstream's wrapping and the fork's feature:
--public-urlnotice and Public URL endpoint (ADR 0010);t3code/no-untranslated-copynow fails lint on unwrapped copy. About 25 web keys and 8 mobile keys are translated by hand into all 9 locales, using upstream's terms.vp run i18n:checkpasses.Re-homed on upstream's structure
isAbsolutePathsits next towithoutRemoteCredentialsandnormalizeProjectPathForComparison.mcpToolListJsonBytesis 58,326, which is upstream's 57,321 plus the fork's unchanged 1,005.AgentContextBudget.test.tsmeasures it.Fixes for new upstream interactions
updateInstancereturn the save result. An earlier sync left the fork'ssyncInstancecall after thatreturn, so it was unreachable on forkmain. Provider edits stopped reaching other environments. The handler now starts the sync and returns the source write's result. Lint'sno-unreachablecaught it.https--public-urlthat warning is false. It is now skipped for HTTPS. The fork's existing public-URL startup test gained an assertion, which failed before the fix.SettingResetButton'slabeltoariaLabel, and the default base branch row follows.ADRs. All ADRs now compare against
aced664ed. Notes were added in 0010, 0016 and 0024. New ADR 0030 records how fork copy is translated on future syncs.Verification
vp run check:changed upstream/main:GitManager.test.ts. The 3 pass withGIT_CONFIG_GLOBAL=/dev/null. They fail because of this host's globalurl.*.insteadOfrules, as the previous sync recorded.vp run i18n:checkpasses for web, mobile and desktop.AgentContextBudget.test.tsandstartupAccess.test.tspass.Not run locally:
libglib-2.0.so.0is missing. CI runs them.mcp-tool-useeval;Translations are machine-authored and unreviewed by a native speaker.
Model: Claude Opus 5.5; harness: Claude Code in T3 Code.
🤖 Generated with Claude Code