Repository navigation
Reduce regular graph construction memory and support NFAs - #234
Merged
Merged
Conversation
zayenz
changed the title
zayenz
force-pushed
the
feature/improved-regular-construction
branch
from
September 28, 2026 17:53
c8363ac to
c9927cd
Compare
zayenz
commented
Oct 4, 2026
zayenz
commented
Oct 5, 2026
zayenz
left a comment
zayenz
left a comment
Member
Author
There was a problem hiding this comment.
No actionable findings in regular graph construction, NFA posting, or cloning. All 14 CI checks pass at c9927cd896.
zayenz
added this pull request to stack #250
October 5, 2026 13:21
zayenz
force-pushed
the
feature/improved-regular-construction
branch
from
October 8, 2026 15:15
c9927cd to
bef9e05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build the regular propagator's layered graph from sparse reachable frontiers instead of reserving every automaton state at every position. Temporary state storage becomes O(k + S), where S is the surviving graph size; persistent storage is unchanged. In the measured unfolded size-5,000 case, peak RSS fell from 108,000 to 9,552 KiB.
Add
DFA::nfa()for epsilon-free NFAs without determinization or minimization. Ordinary DFA constructors retain their deterministic-transition requirement. Cloning preserves branching NFA paths when removing assigned prefixes.Regular-constraint tests pass in audited Debug, including differential and cloning cases. The earlier memory measurements were not repeated after the NFA addition.