Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -1530,8 +1530,8 @@ impl InputTypeConstraint {
}
}

/// Check if a type reaches the constraint through an `input_adapter`, the per-connector node which the preprocessor places ahead of
/// every ranked connector to convert or embed a convertible element, such as a color literal feeding a `Graphic` paint wire.
/// Check if a type reaches the constraint through any `input_adapter`, which converts or embeds a convertible element (such as a color literal feeding a
/// `Graphic` paint wire) ahead of an input registered with one ranked type. Whether this input is one that gets an adapter isn't checked.
#[must_use]
fn satisfies_through_input_adapter(&self, ty: &Type) -> bool {
let provided = Self::type_name(ty);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ use crate::messages::portfolio::document::utility_types::document_metadata::Laye
use crate::messages::portfolio::document::utility_types::layers_in_view::LayersInView;
use crate::messages::portfolio::document::utility_types::misc::GroupFolderType;
use crate::messages::portfolio::document::utility_types::network_interface::{
self, FlowType, GlideOffsets, ImportOrExport, InputConnector, NodeNetworkInterface, NodeTypePersistentMetadata, OutputConnector, Previewing, RootNode, TransactionCheckpoint, type_feeds_connector,
self, FlowType, GlideOffsets, ImportOrExport, InputConnector, NodeNetworkInterface, NodeTypePersistentMetadata, OutputConnector, Previewing, RootNode, TransactionCheckpoint,
};
use crate::messages::portfolio::document::utility_types::nodes::{CollapsedLayers, LayerPanelChainInsertion, LayerPanelChainNode, LayerPanelEntry};
use crate::messages::portfolio::document::utility_types::wires::{GraphWireStyle, WirePath, WirePathUpdate, build_vector_wire};
Expand Down Expand Up @@ -2928,10 +2928,7 @@ impl NodeGraphMessageHandler {

hidden_value
&& !network_interface.is_internal_input(&node_id, input_index, network_path)
&& network_interface
.potential_valid_input_types(&input_connector, network_path)
.iter()
.any(|valid_type| output_types.iter().any(|output_type| type_feeds_connector(output_type, valid_type)))
&& output_types.iter().any(|output_type| network_interface.input_accepts_type(&input_connector, output_type, network_path))
Comment thread
cubic-dev-ai[bot] marked this conversation as resolved.
})
.collect::<Vec<_>>();
if revealed_input_indices.is_empty() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ mod validation;
mod view;

pub use editor_delta::{EditorDelta, NetworkMetadataChange, NodeMetadataChange};
pub use resolved_types::type_feeds_connector;
use store::Guarded;
pub use store::NodeLocator;
pub use template::*;
Expand Down
Loading
Loading