Skip to content

Derive node ids for resources and animation curves deterministically - #4759

Merged
TrueDoctor merged 1 commit into
masterfrom
resource-node-stable-id
Oct 20, 2026
Merged

TrueDoctor merged 1 commit into
masterfrom
resource-node-stable-id

Conversation

@TrueDoctor

Copy link
Copy Markdown
Member

Derive the IDs of the resource and curve nodes the preprocessor inserts from the resource and the consuming input, so recompiles keep their proto nodes even if they take the document node path as input

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 3 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread node-graph/preprocessor/src/lib.rs Outdated
Comment thread editor/src/node_graph_executor/recompile_tests.rs
Comment thread node-graph/preprocessor/src/lib.rs
…ts from the resource and the consuming input, so recompiles keep their proto nodes
@TrueDoctor
TrueDoctor force-pushed the resource-node-stable-id branch from 739901e to c6024d8 Compare October 20, 2026 18:12
@TrueDoctor
TrueDoctor added this pull request to the merge queue Oct 20, 2026
Merged via the queue into master with commit 7654304 Oct 20, 2026
11 checks passed
@TrueDoctor
TrueDoctor deleted the resource-node-stable-id branch October 20, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants