Repository navigation
Explain how to reach a NAS on a private network in the File Search wizard - #1805
Merged
Merged
Conversation
…zard On Cloud, a NAS address that only works inside the user's network (192.168.x.x, nas.local, a QuickConnect link) or a connection test that cannot reach the server now shows how to make the NAS reachable: Synology WebDAV over HTTPS with a synology.me name, a tunnel, other NAS, the Cloud's outbound address for the firewall, and a switch to WebDAV. Self-hosted instances are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
People who open File Search to search their NAS usually type the NAS's LAN address (192.168.x.x,
nas.local) or a Synology QuickConnect link. AnythingMCP Cloud cannot reach those, and until now the wizard only showed a one-line error. In the last two days every new File Search account that tried this stopped there, mostly on the Synology preset withprivate_addressorunreachableerrors.This PR explains, right in the wizard, how to make the NAS reachable from the internet.
Changes
lib/private-host.ts: recognises private IPs (RFC 1918, loopback, link-local, CGNAT/Tailscale, IPv6 ULA/link-local), names without a dot, home-network suffixes (.local,.lan,.fritz.box…) and QuickConnect links. It is only a hint; the backend SSRF guard still decides what can be connected.components/file-search/nas-reachability-help.tsx: a help box with three ways to make the NAS reachable: Synology WebDAV over HTTPS with a free synology.me name and Let's Encrypt; a tunnel (Cloudflare Tunnel, Tailscale Funnel); QNAP, Fritz!Box and other NAS. It also shows the Cloud's outbound address(es) for the NAS firewall, mentions self-hosting, and has a "Switch to WebDAV" button.private_address,unreachableortimeout.capabilities.cloud).Type
Cloud and self-hosted
Testing
tests/e2e/file-search-nas-reachability.spec.ts, 4 tests with mocked API:Commands and results, all in
packages/frontend:npx tsc --noEmit -p tsconfig.json: no errors.npx eslinton the changed files: 0 errors, 1 warning that already exists (react-hooks/set-state-in-effectonloadCaps, untouched).next dev --webpack --port 3100, thenPLAYWRIGHT_USE_RUNNING_SERVER=1 npx playwright test tests/e2e/file-search-nas-reachability.spec.ts --workers=1: 4 passed.Checklist
docs/; the guidance lives in the productnpm test): frontend-only change; the frontend has nonpm testRelated Issues
None. No backend or
ee/change.