Repository navigation
feat: hosted clients for PATH, NJ Transit rail, NYC Ferry, Citi Bike, LIRR, Metro-North (2.4.0) - #12
Merged
Conversation
… LIRR, Metro-North Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds SDK namespaces for the regional providers mtaapi.dev already serves, so the docs can show SDK code instead of curl. All of them go through the existing
hostedJson(same auth headers and missing-apiKeyerror). Response types followdocs/openapi.jsonin mta-api.lirrandmetroNorthshare oneCommuterRailClientwith different base paths. Path params (route, Citi Bikeid) are URL-encoded.Bumps the version to
2.4.0. Publishing still needs av2.4.0tag after merge (publish.yml). The mta-api docs PR says "Requires mta-js 2.4.0", so publish before that one merges.bun test index.test.ts(22 pass) andbun run typecheckpass. Hosted integration tests were added but not run locally because noMTA_API_KEYwas set.Link to Devin session: https://app.devin.ai/sessions/0c4a45aeae754724bd092a6abc7e1004
Open in Devin Desktop: https://app.devin.ai/desktop/session/0c4a45aeae754724bd092a6abc7e1004?variant=devin
Requested by: @[REDACTED SECRET]