Repository navigation
feat: hosted clients for MBTA, BART, King County Metro, CapMetro, Pace, Tri-Rail, Brightline, and bike shares - #13
Merged
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds SDK clients for the new mtaapi.dev agencies. They reuse the existing client classes, so this is mostly constructor wiring:
Type changes:
CitiBikeClientnow takes abasePathargument.citiBikestill uses/api/v1/citi-bike.CommuterRailModeand the bikemode/sourceunions are widened to include the new systems.CommuterRailStop.parentStation?andCommuterRailRoute.type?(the GTFSroute_type) are new.StopModeis unchanged: the new agencies aren't in the cross-mode stops snapshot.The API endpoints these call are in mta-api #107 (MBTA, with the other agencies stacked on it) and #108 (bike shares). The version isn't bumped.
Testing
bun testpasses (25), with new exact-URL tests formta.mbtaandmta.bayWheels.bun run typecheckpasses.Link to Devin session: https://app.devin.ai/sessions/8d319beac0174974a184312ce7c14932
Open in Devin Desktop: https://app.devin.ai/desktop/session/8d319beac0174974a184312ce7c14932?variant=devin
Requested by: @gtokman