Repository navigation
Add portable conditional KV records across providers - #510
Draft
ChristianPavilonis wants to merge 9 commits into
Draft
ChristianPavilonis wants to merge 9 commits into
ChristianPavilonis wants to merge 9 commits into
Conversation
Preserve record and current stock-service/Geo ancestry. Add the service record API, prepared Rust client, generated TLS proofs and two-node resend/deadline/takeover checks. Local checkpoint only. Native SDK, stock celld and strict lint checks pass; final SDK acceptance remains blocked by an observed Viceroy concurrent-CAS defect. Keep exact-one-winner assertions unchanged.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
edgezero-coreedgezero-store-awsservices/celld-storeedgezero-store-celldCloses
Closes #472
Closes #473
Stack placement
Base this PR on #439. #454 belongs above this PR; #464 belongs above #454 but remains outside official stack membership. Preserve existing PR identities and ordinary forward-merge ancestry.
flowchart TD A["#439: native Geo"] --> B["This PR: conditional records"] B --> C["#454: KV-backed Geo"] C --> D["#464: error finalization, outside stack membership"]Test plan
Local verification uses Rust 1.98.1 with locked dependencies.
cargo test --workspace --all-targetsafter merging current Add pluggable native Geo providers and protected CloudFront ingress #439. Follow-up lint-only changes also pass the affected adapter and example tests.cargo clippy --workspace --all-targets --all-features -- -D warningscargo fmt --all -- --checkcargo check --workspace --all-targets --features "fastly cloudflare spin"examples/app-demonative workspace tests and strict all-target/all-feature Clippy.Known validation gap
The Viceroy emulator's record race can report more than one successful CAS writer. The one-winner assertion remains unchanged and the failed result remains disclosed. The emulator checks and replacement use separate locking intervals. Its repair is explicitly deferred; no retries for a favorable schedule, serialization, weakened assertions or runtime patch are included here. Successful individual runs do not establish atomicity. This does not establish a production Fastly defect or qualify the full Fastly concurrency acceptance criterion in #472.
Operational limits
Stock celld retains one serialized namespace object and allocator. Same-instance snapshot rollback/restore is not protected. Local/emulator proofs do not qualify production IAM, capacity, hosted fleets, backups or deployment. Native connector credentials remain outside published application configuration. No release, deployment, infrastructure apply or image publication is part of this PR.
Checklist