Repository navigation
Enforce absolute deadlines for auction response collection #1433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
d4f7018
Enforce absolute deadlines for auction response collection
prk-Jr 62ad0d9
Record deadline verification and independent PR review
prk-Jr 23b5b4c
Clarify worker collection and expected deadline disconnects
prk-Jr 8b367bc
Preserve dispatched bids and verify runtime deadline behavior
prk-Jr a0b592c
Run deadline regression harnesses with Node.js
prk-Jr 3453298
Harden auction deadline isolation and cutoff enforcement
prk-Jr 879693b
Install Clippy for worker runtime fixture checks
prk-Jr 9077952
Merge branch 'main' into fix/1015-auction-deadlines
prk-Jr 1f53384
Merge branch 'main' into fix/1015-auction-deadlines
aram356 270236c
Merge branch 'main' into fix/1015-auction-deadlines
prk-Jr 5728378
Share worker deadlines and align auction tests
prk-Jr 018b8de
Merge main into auction deadline fixes
prk-Jr 1432675
Merge branch 'main' into fix/1015-auction-deadlines
prk-Jr 157b8b2
Merge main into auction deadline fixes
prk-Jr e1a34e9
Tighten deadline regressions and clarify worker adapter limits
prk-Jr 1319998
Merge branch 'main' into fix/1015-auction-deadlines
prk-Jr 5927402
Group Fastly deadline test imports above the first test
prk-Jr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| name: Worker auction deadline runtime regressions | ||
|
|
||
| on: | ||
| pull_request: | ||
| push: | ||
| branches: [main] | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| worker-deadlines: | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 30 | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| adapter: [cloudflare, spin] | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Read tool versions | ||
| id: versions | ||
| shell: bash | ||
| run: | | ||
| { | ||
| echo "node=$(awk '$1 == "nodejs" { print $2 }' .tool-versions)" | ||
| echo "spin=$(awk '$1 == "spin" { print $2 }' .tool-versions)" | ||
| echo "bindgen=$(sed -n '/^name = "wasm-bindgen"$/ { n; s/version = "\(.*\)"/\1/p; }' Cargo.lock)" | ||
| } >> "$GITHUB_OUTPUT" | ||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: ${{ steps.versions.outputs.node }} | ||
| - name: Set up Rust | ||
| uses: ./.github/actions/setup-rust | ||
| with: | ||
| target: ${{ matrix.adapter == 'cloudflare' && 'wasm32-unknown-unknown' || 'wasm32-wasip1' }} | ||
| components: clippy | ||
| cache-key: worker-deadline-${{ matrix.adapter }} | ||
| - name: Install JS dependencies | ||
| working-directory: crates/trusted-server-js/lib | ||
| run: npm ci | ||
| - name: Build actual adapter HTTP fixture | ||
| shell: bash | ||
| run: | | ||
| if [ "${{ matrix.adapter }}" = cloudflare ]; then | ||
| cargo build --locked -p trusted-server-adapter-cloudflare --example deadline-runtime --target wasm32-unknown-unknown --features cloudflare | ||
| else | ||
| cargo build --locked -p trusted-server-adapter-spin --example deadline-runtime --target wasm32-wasip1 --features spin | ||
| fi | ||
| - name: Lint runtime fixture | ||
| shell: bash | ||
| run: | | ||
| if [ "${{ matrix.adapter }}" = cloudflare ]; then | ||
| cargo clippy --locked -p trusted-server-adapter-cloudflare --example deadline-runtime --target wasm32-unknown-unknown --features cloudflare -- -D warnings | ||
| else | ||
| cargo clippy --locked -p trusted-server-adapter-spin --example deadline-runtime --target wasm32-wasip1 --features spin -- -D warnings | ||
| fi | ||
| - name: Install local Cloudflare tools | ||
| if: matrix.adapter == 'cloudflare' | ||
| shell: bash | ||
| run: | | ||
| npm install --global wrangler@4.83.0 | ||
|
prk-Jr marked this conversation as resolved.
Resolved
prk-Jr marked this conversation as resolved.
Resolved
|
||
| mkdir -p "$RUNNER_TEMP/bindgen" | ||
| # Digests are published with the upstream GitHub release assets. | ||
| # Update the digest alongside the pinned version. | ||
| test "${{ steps.versions.outputs.bindgen }}" = 0.2.126 | ||
| archive="$RUNNER_TEMP/wasm-bindgen.tar.gz" | ||
| curl --fail --location --silent --show-error "https://github.com/wasm-bindgen/wasm-bindgen/releases/download/${{ steps.versions.outputs.bindgen }}/wasm-bindgen-${{ steps.versions.outputs.bindgen }}-x86_64-unknown-linux-musl.tar.gz" --output "$archive" | ||
| echo "064948d58e2d6c0a745216477a639ba696216d6309aaa902939d1b865b1d869d $archive" | sha256sum --check | ||
| tar -xz --strip-components=1 -C "$RUNNER_TEMP/bindgen" -f "$archive" | ||
| echo "$RUNNER_TEMP/bindgen" >> "$GITHUB_PATH" | ||
| - name: Install pinned Spin runtime | ||
| if: matrix.adapter == 'spin' | ||
| shell: bash | ||
| run: | | ||
| mkdir -p "$RUNNER_TEMP/spin" | ||
| # Update the published upstream digest alongside the pinned version. | ||
| test "${{ steps.versions.outputs.spin }}" = 4.1.0 | ||
| archive="$RUNNER_TEMP/spin.tar.gz" | ||
| curl --fail --location --silent --show-error "https://github.com/spinframework/spin/releases/download/v${{ steps.versions.outputs.spin }}/spin-v${{ steps.versions.outputs.spin }}-linux-amd64.tar.gz" --output "$archive" | ||
| echo "aeeb892f94cf861f5302546faa0bdaa82cc4be30539621299746a6dc011f3b5a $archive" | sha256sum --check | ||
| tar -xz -C "$RUNNER_TEMP/spin" -f "$archive" | ||
| echo "$RUNNER_TEMP/spin" >> "$GITHUB_PATH" | ||
| - name: Exercise delayed headers, trickling bodies, and slow publisher work | ||
| shell: bash | ||
| env: | ||
| WRANGLER_SEND_METRICS: 'false' | ||
| run: | | ||
| if [ "${{ matrix.adapter }}" = cloudflare ]; then | ||
| node scripts/test-worker-auction-deadlines.mjs cloudflare --runtime "$(command -v wrangler)" | ||
| else | ||
| node scripts/test-worker-auction-deadlines.mjs spin --runtime "$(command -v spin)" | ||
| fi | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.