Skip to content

Add server-side identity on every adapter spec and plan - #1559

Open
aram356 wants to merge 36 commits into
mainfrom
spec/identity-axum
Open

aram356 wants to merge 36 commits into
mainfrom
spec/identity-axum

Conversation

@aram356

@aram356 aram356 commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

PRfection phase: plan

Summary

  • Adds the design for server-side identity on every adapter: Axum deployable from main; the Edge Cookie and its record on Fastly, Axum, Cloudflare and Spin, delivered in that order, with Fastly and Axum shippable without any Cloudflare or Spin work; SharedID handled the way Prebid defines it, with EID consent; shared state passed correctly; and identity written back as first-party cookies on the document response and through the same-origin EC route.
  • Adds the plan: GitHub tasks in dependency order that file the missing tickets under the new epics (Server-side identity on every adapter #1558 and Platform capabilities for server-side identity on every adapter edgezero#468), move the existing issues under them without nesting epics, link every blocked-by dependency and tie out the existing PRs, plus the dependency waves those tickets follow.
  • Docs only. No code changes.

Changes

File Change
docs/superpowers/specs/2026-11-11-server-side-identity-all-adapters-design.md New. Goals, relationship to #1236 and #1506, where things stand, how the EC record write is split, platform support per adapter, requirements AX, ID (including the ID-9 EC route), SH, SID, WB and EZI each with an Accept: line, configuration, consent and privacy, failure handling, compatibility and rollout, decisions DEC-1 to DEC-21, how the claims were checked, review log. Where things stand includes the two rc/identity integration branches as read on 2026-11-15
docs/superpowers/plans/2026-11-11-server-side-identity-all-adapters.md New, in writing-plans format. Part A: the state on 2026-11-15, stacking with heads, and dependency waves that interleave Trusted Server and EdgeZero tickets, PR fixes, merges and integration-branch revisions; waves 0 to 9 finish Fastly and Axum with no Cloudflare or Spin blocker. Part B: tickets split by platform (22 new EdgeZero tickets plus 10 moved issues under IABTechLab/edgezero#468; nine new A tickets, T1 to T22 without T7 or T14, and 16 moved issues under #1558) with type, size, priority, blocked-by and blocks. Part C: per-PR fixes with the head each was checked at. Tasks 1 to 8, which ran on 2026-11-13 and expected 45 sub-issues under #1558 and 32 under IABTechLab/edgezero#468; with the issues moved or filed since, the epics hold 48 and 37

Closes

Refs #1558 and IABTechLab/edgezero#468. Neither epic closes with this PR.

Spec

Spec: docs/superpowers/specs/2026-11-11-server-side-identity-all-adapters-design.md (this PR). It is a program-level design, not the design #1236 asks for; #1236 has a note saying so. Its review log records eight rounds, the plan run and a state refresh:

  • Round 1: reviews 5871533635 and 5871619954 at 00df85414, 34 findings.

  • Round 2: review 5875159165 at 7cb8933f7, 6 still open plus 2 new should-fix.

  • Round 3: review 5877498110 at fbdfbedef, which resolved those eight and opened thread 37.

  • Round 4: reviews 5881124556 and 5881450878 at c4417b7f8, 66 threads (3 blocking). The commits from d2523f444 to 8e564f24c address all 66 plus thread 37, and each thread holds its CREATOR: disposition.

  • Round 5: review 5884927046 at 8e564f24c, which resolved 65 of them (101 in all) and kept threads 40 and 58 open on one issue: an intervening withdrawal could be coalesced away. 3bbd297ed keeps a waiting withdrawal as a barrier and adds the three-event Accept case. After a main merge (de7b2268c, bringing Bypass cache for signed S3 image preflights #1516), 403a62a5f records Bypass cache for signed S3 image preflights #1516's merge and the moved Unify the AWS example with CloudFront and durable Edge Cookie storage #1540 and Axum readiness RC #1541.

  • Round 6: review 5885768720 at de7b2268c, which resolved threads 40 and 58 (all 103) with an APPROVE verdict; 403a62a5f then moved the head past it.

  • Round 7: review 5885982220 at 403a62a5f, which kept all 103 and opened one should-fix (thread 104): Unify the AWS example with CloudFront and durable Edge Cookie storage #1540's new head already selects CloudFront geo. c7dc9de77 updates AX-3, AX-6 and Part C.

  • Round 8: review 5886170878 at c7dc9de77, which kept all 104 and gave an APPROVE verdict.

After round 8:

Skills: superpowers:writing-plans for the plan. The design follows the brainstorming design-doc conventions; its approval gate is the maintainer's sign-off on the design as a whole. DEC-1 to DEC-7, DEC-10, DEC-11 and DEC-16 to DEC-21 are decided. Open: DEC-8 (Cloudflare and Spin store), DEC-9 (LiveRamp Custom ID, which the MVP waits on through T22), DEC-12, DEC-13, DEC-14 and DEC-15 (rate limiting, deferred past the MVP).

Notes for reviewers

  • Evidence. Every "not implemented" claim comes from reading code at named revisions across main, every open PR head in both repositories, the RC tags, branches with no PR, and PRs merged or closed since 2026-10-01. PR bases and heads were read on 2026-11-12; Part A's State and the spec's Integration branches were read on 2026-11-15.
  • Scope. The cutover is Cut Trusted Server over to EdgeZero PR 275 #1506 (DEC-1). Platform order is Fastly, Axum, Cloudflare, Spin (DEC-4). Fastly and Axum are the MVP (DEC-2, waves 0 to 9); Cloudflare and Spin follow it. A script over Part A and Part B confirms that none of the 50 MVP items waits on a later wave or an any row, that every Blocks entry mirrors a Blocked-by entry, that no ticket is less urgent than what it blocks, and that each wave row's priority matches Part B.
  • Out of scope. Attestation and packaging (DEC-19).

Board

With 3314edbd7 the board matches the plan: every Part B row's size and priority equals its board field, and every issue under the epics has a Part B row. IABTechLab/edgezero#488 to IABTechLab/edgezero#493 are retitled as integration-branch revisions, and the 22 other bodies that quoted their old titles, AX-7's tag rule or closed IABTechLab/edgezero#463 are updated. IABTechLab/edgezero#503 joined IABTechLab/edgezero#468 at P3, size S. IABTechLab/edgezero#482, IABTechLab/edgezero#488 and #1507 moved to In review.

Test plan

Docs-only change, so the docs gates ran at c1c0a7226:

  • docs/node_modules/.bin/prettier --config docs/.prettierrc --check on both files: exit 0, All matched files use Prettier code style!
  • ts dev lint domains --changed-vs 1810c763a (the PR base): exit 0, no findings
  • git diff --check 1810c763a...HEAD: exit 0
  • Relative links and anchors in both files: 9 checked, 0 broken

npm run lint and npm run build do not cover these files, since docs/.vitepress/config.mts excludes superpowers/**. CI runs the full matrix on the PR.

Checklist

  • Feature PRs: spec linked above, ending in a review log of two or more agent review rounds
  • Changes follow AGENTS.md conventions
  • No secrets or credentials committed

@aram356 aram356 self-assigned this Nov 12, 2026
Requirements for Axum deployability, identity on all four adapters, SharedID handling, shared state and first-party write-back, plus the merge order, epic tickets and fixes to existing PRs.

@aram356 aram356 left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REVIEWER: REQUEST_CHANGES. GitHub blocked this review event with HTTP 422, "Review Can not request changes on your own pull request", because the reviewer and the PR author are the same account. This COMMENT carries the REQUEST_CHANGES verdict.

Self-review of the spec and plan at 00df85414 in one-account mode: author and reviewer share the aram356 login. 32 inline findings: 7 blocking, 16 should-fix, 9 nits. Findings about text that 00df85414 removed are not repeated here.

Blocking

  • Phase B waits on outside EdgeZero work with no fallback (plan 59).
  • No phase delivers or releases E2 to E5 (plan 66-68).
  • Several requirements have no owning ticket (plan 99).
  • Tickets that bring up the EC lifecycle off Fastly omit geo, rate limiter, after-response and record dependencies (plan 119).
  • The E and EZ numberings disagree, and the EZ IDs collide with #1506's (plan 132).
  • E1 never names Fastly, yet T8 deletes the Fastly backend (plan 134).
  • The spec has no review log, which CONTRIBUTING.md:85-99 requires before the PR leaves draft (spec 468).

Not anchored to a line. The PR body's test plan checks npm run lint and npm run build, but docs/.vitepress/config.mts:52-53 excludes superpowers/**, so neither touches these files. Only the Prettier check and the domain lint cover them.

Verification

The full CI gate list from AGENTS.md (gates 1 to 16, plus the host CLI tests) ran at e60213fc4 in a detached worktree. The head then moved to 00df85414, which changes only the two Markdown files (git diff --stat e60213fc4 00df85414: 2 files changed, 6 insertions(+), 16 deletions(-)). Every gate exited 0:

  • cargo fmt --all -- --check
  • all eight clippy aliases
  • cargo test-fastly (test result: ok. 30 passed; 0 failed; 20 ignored, last result block), cargo test-fastly-reuse, cargo test-axum, cargo test-cloudflare, cargo test-spin, cargo test --package trusted-server-cli --target aarch64-apple-darwin
  • parity (test result: ok. 29 passed; 0 failed)
  • build-digest test and clippy
  • JS: npx vitest run (Tests 3298 passed | 1 skipped (3299)) and npm run format
  • docs format, lint and build, and Markdown outside docs/
  • wasm clock lint, docs-proposal scripts, CI Node pin guard, release scripts
  • ts dev lint domains --changed-vs origin/main
  • Fastly deadline fixtures (test result: ok. 5 passed; 0 failed)
  • Spin worker deadline build and run

Gate 15 (Cloudflare worker deadlines) first exited 1 on this machine: the local wasm-bindgen CLI was 0.2.121 while Cargo.lock pins 0.2.126 ("rust Wasm file schema version: 0.2.126 / this binary schema version: 0.2.121"). With wasm-bindgen 0.2.126 and wrangler 4.83.0, the versions CI installs, it exited 0 with four PASS cloudflare lines.

At 00df85414 the affected gates exited 0: docs install, format, lint and build, Markdown outside docs/, and ts dev lint domains --changed-vs origin/main (scanned 248 lines in the plan, scanned 468 lines in the spec). CI at 00df85414: 30 checks, all successful.

Next actor: CREATOR, to address the inline findings and add the review log.

@aram356 aram356 left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REVIEWER: REQUEST_CHANGES — GitHub blocked this review event with HTTP 422: "Review Can not request changes on your own pull request". Submitting the intended verdict as a COMMENT with the inline findings preserved; this is not a formal change-request review.

Spec/plan review at 00df85414232048510cf76131d102827ab20e0c2 (base 598a8517072c52690a6b1833e8797d9003f3dba5). Acting reviewer and PR author are both aram356 (one-account mode).

Two new inline findings:

  • blocking: SharedID write-back must require EID consent in addition to EC permission and opt-out checks; Purpose 1 alone does not authorize EIDs when Purpose 4 is denied.
  • should-fix: T9 must collect provider results before document finalization; its “collect after the response” wording contradicts ID-4.

Three independently checked findings are already covered by open threads and are not duplicated:

  • Spin issuance needs a supported geo dependency: #1559 (comment)
  • Assign the configured SharedID cache guard to T2: #1559 (comment)
  • Treat this as a roadmap with reviewed execution/validation plans before implementation: #1559 (comment)

I read the complete updated diff, both documents, the linked issues, surrounding source, and all 32 existing review threads and replies. Existing findings remain open; this pass accepts or resolves none of them.

The user explicitly instructed in this review session: “Yes—docs checks only; submit now”, waiving PRfection's full-suite requirement for this docs-only PR. Remaining runtime validation was stopped. Broader partial runs and setup failures are not claimed as a passing full suite or attributed to this PR. The scoped docs checks below were independently executed at this head in detached worktree .worktrees/review-1559-00df854.

$ cd docs && npm run lint
exit=0
> eslint .
$ cd docs && npm run format
exit=0
All matched files use Prettier code style!
$ cd docs && npm run build
exit=0
build complete in 8.02s.
$ docs/node_modules/.bin/prettier --config docs/.prettierrc --check "*.md" ".claude/**/*.md" ".github/**/*.md" "crates/**/*.md" "scripts/**/*.md" "tinybird/**/*.md"
exit=0
All matched files use Prettier code style!
$ git diff --check 598a8517072c52690a6b1833e8797d9003f3dba5...HEAD
exit=0
(no stdout/stderr)

Docs lint/build are project-level checks: VitePress excludes superpowers/**, so their success is not evidence of these documents' content or links. Prettier and direct source/spec review cover the changed Markdown.

Next actor: CREATOR. Address the new findings and the existing open threads with CREATOR: dispositions and fixing commits, record the required review rounds/approval trail, and hand back for re-review. Keep this PR in draft. No approval or merge-readiness claim is made.

Rename the spec to a design doc and the plan to the writing-plans format. Add acceptance criteria, platform support with the Fastly, Axum, Cloudflare, Spin order, SharedID EID consent, configuration, consent, failure and rollout sections, and a review log. Rebuild the plan as ordered GitHub tasks with fixed dependencies, per-platform phases, EdgeZero releases and per-PR tie-out items.
@aram356
aram356 marked this pull request as ready for review November 12, 2026 09:17
@aram356

aram356 commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator Author

CREATOR: Ready for review round 2 at a3a22fe7f. Account mode: one-account, acting login aram356 for both roles.

All 34 threads from reviews 5871533635 and 5871619954 have a fixed disposition in their own thread, and none is resolved. The main changes:

  • Spec. Renamed to docs/superpowers/specs/2026-11-11-server-side-identity-all-adapters-design.md. It adds a Platform support section with the Fastly, Axum, Cloudflare, Spin order (DEC-4). Every requirement has an Accept: line. New SID-6 covers EID consent. New sections cover configuration, consent and privacy, failure handling, compatibility and rollout, and how the claims were checked. Decisions are DEC-1 to DEC-14, and there is a review log.
  • Plan. Renamed to docs/superpowers/plans/2026-11-11-server-side-identity-all-adapters.md, in writing-plans format. It has the merge order with heads and the Phase B fallback; EdgeZero releases R1 to R4; per-platform Phase D; ticket tables with dependencies, blocking decisions and phases (EZI-1 to EZI-6, A1 to A9, T1 to T16); and Part C per-PR fixes with heads. Tasks 1 to 7 file and tie out in dependency order.
  • GitHub. I updated Server-side identity on every adapter #1558's Done-when and Related and noted on Make the Axum adapter a supported self-hosted deployment target #1236 that this is not its spec.

Validation, docs gates only: Prettier check exit 0, All matched files use Prettier code style!; ts dev lint domains --staged --verbose exit 0, scanned 402 lines (plan) and scanned 508 lines (spec).

Next actor: REVIEWER.

Replace the phases with dependency waves that interleave Trusted Server and EdgeZero tickets, PR fixes, merges and releases. Add type, size, priority, blocked-by and blocks to every ticket, list the existing issues moved under each epic, keep the epics unnested, and add a task that links the blocked-by dependencies.
Split every EdgeZero ask and Trusted Server ticket by platform so no Fastly or Axum item is blocked by a Cloudflare or Spin item, add Cloudflare and Spin follow-on tickets, file the Axum tickets and the moved issues under the new epics instead of nesting epics, and record the platform order with the stand-alone rule in DEC-4.
@aram356

aram356 commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator Author

CREATOR: The head moved to 7cb8933f7 before round 2 started. It applies two maintainer decisions and adds the dependency order:

Validation, docs gates only: Prettier check exit 0, All matched files use Prettier code style!; ts dev lint domains --staged --verbose exit 0.

Next actor: REVIEWER.

@aram356 aram356 left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REVIEWER: REQUEST_CHANGES — GitHub blocked the formal event: HTTP 422, "Review Can not request changes on your own pull request". Both logins are aram356; this COMMENT preserves the intended verdict and both inline findings.

Round-2 spec/plan re-review at 7cb8933f7ebdad099921dcad6cb8391a57e83d47 (base 598a8517072c52690a6b1833e8797d9003f3dba5). Acting REVIEWER and PR author: aram356, one-account mode. Reviewed both complete documents and the updated diff, all 34 original threads and CREATOR dispositions, the fixing revisions, issue parentage and current checks. The plan received separate dependency-order and requirement-coverage passes.

28 CREATOR fixes are independently accepted and resolved. Six original threads remain open, with the exact remaining correction in each thread. Two distinct new inline findings cover Task 1's reparenting procedure and WB-3's companion-cookie acceptance. The issue allocation/counts now reconcile to 43 Trusted Server and 21 EdgeZero issues; the declared dependency graph has no cycle, and the latest platform split removes Cloudflare/Spin blockers from the Fastly/Axum release path. The remaining plan corrections concern fallback timing, omitted decision gates, the RC-unit head guard and the executable issue-move procedure. This phase needs another CREATOR revision.

Verification followed the user's explicit instruction: "Yes—docs checks only; submit now". The runtime/build/full CI suite was not rerun locally for these Markdown revisions. All commands below ran in my detached current-head worktree through prf_run; the Prettier executable and unchanged domain-linter binary came from my earlier reviewer worktrees.

  1. /Users/ag/projects/iab/trusted-server/.worktrees/review-1559-a3a22fe/docs/node_modules/.bin/prettier --config docs/.prettierrc --check docs/superpowers/plans/2026-11-11-server-side-identity-all-adapters.md docs/superpowers/specs/2026-11-11-server-side-identity-all-adapters-design.md — exit 0:
Checking formatting...
All matched files use Prettier code style!
  1. /Users/ag/projects/iab/trusted-server/.worktrees/review-1559-e60213f/target/aarch64-apple-darwin/debug/ts dev lint domains --changed-vs 598a8517072c52690a6b1833e8797d9003f3dba5 --verbose — exit 0:
scanned 565 lines in docs/superpowers/plans/2026-11-11-server-side-identity-all-adapters.md
scanned 520 lines in docs/superpowers/specs/2026-11-11-server-side-identity-all-adapters-design.md
  1. git diff --check 598a8517072c52690a6b1833e8797d9003f3dba5...HEAD — exit 0, no output.
  2. python3 /tmp/prfection-1559-r2/check-links.py — exit 0: Relative Markdown links and anchors: 5 checked, 0 broken.

GitHub Actions readback at this head separately reports success for CodeQL Advanced, Integration Tests, Worker auction deadline runtime regressions, Run Format and Run Tests. Those are CI results, not my local suite execution.

Every original finding's disposition is recorded below; each link identifies its original thread. Outdated anchors were not treated as proof of a fix.

Original finding This review Subject
1 Open Fallback clock still waits for the stalled fold-in
2 Accepted; resolved EdgeZero releases have platform-specific owners and gates
3 Accepted; resolved Missing requirement owners assigned
4 Accepted; resolved Lifecycle and later-platform prerequisites assigned
5 Accepted; resolved One EZI numbering and requirement mapping
6 Accepted; resolved Conditional-store contract and T6 release gate
7 Open Round-2 record and clean-review/draft gate remain
8 Accepted; resolved Plan format and GitHub task interfaces
9 Accepted; resolved Port #1528 onto #1506 outbound API
10 Accepted; resolved Independent EdgeZero PR ordering
11 Accepted; resolved Check both EID fields for absence
12 Accepted; resolved Epic #1558 scope and completion criteria
13 Accepted; resolved Single ownership for SharedID and store work
14 Open SH-1 acceptance contradicts the Axum HTTP exception
15 Open RC-unit checked baseline still unspecified
16 Accepted; resolved Repository-qualified EdgeZero references
17 Accepted; resolved #1236 remains a separate spec-first epic
18 Open ID-5 acceptance contradicts Spin after-response support
19 Accepted; resolved Page-load versus other record writes
20 Accepted; resolved Acceptance, configuration, privacy and migration sections
21 Accepted; resolved Plan owns the execution sequence
22 Accepted; resolved IPv6 code versus infrastructure ownership
23 Open DEC-5/6 and DEC-11 gates missing from plan blockers
24 Accepted; resolved Audit methods recorded
25 Accepted; resolved #1424 independent main-based PR
26 Accepted; resolved UA state distinguished by branch
27 Accepted; resolved Contiguous T1-T18 numbering
28 Accepted; resolved Complete provider pull-sync path
29 Accepted; resolved Generic deployment example
30 Accepted; resolved ID-2 acceptance excludes test-only stores
31 Accepted; resolved Overlap counts and units corrected
32 Accepted; resolved RC follow-up commit distinguished from merges
33 Accepted; resolved SharedID read/persist/write-back gated by EID consent
34 Accepted; resolved Provider lookup results collected before finalization

Next actor: CREATOR. Correct the six outstanding threads and two new findings, record this round and its remaining findings in the review log, and supply a new head for re-review. No approval or merge-readiness claim is made.

…y epic

Move IABTechLab/edgezero 397, 410, 432, 437 and 438 under IABTechLab/edgezero 468 in the plan, with type, size, priority and blocked-by links, and point R1, EZI-2b, EZI-4c, EZI-4s and the Axum ClientInfo issue at them instead of at their PRs.
@aram356
aram356 marked this pull request as draft November 12, 2026 15:34
Start the wave-1 fallback clock from the Trusted Server merges, make SH-1, ID-5 and WB-3 acceptance match their exceptions, pin the RC-unit baseline and heads, restore the decision gates in the ticket cells, re-parent moved issues in Task 1, and record round 2 in the review log.
@aram356
aram356 marked this pull request as ready for review November 12, 2026 15:37
@aram356

aram356 commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator Author

CREATOR: Ready for review round 3 at 0a579977b. Account mode is one-account: aram356 acts as both roles.

All eight open items from review 5875159165 have a fixed reply in their own thread, and none is resolved:

  • Thread 1. The fallback clock now starts when Carry Sourcepoint TCF consent to Trusted Server #1557, Make shared EC persistence awaitable #1526 and Bypass cache for signed S3 image preflights #1516 have merged, so a stalled fold-in cannot hold it.
  • Thread 7. The review log records round 2. The PR went back to draft while the changes were made and is ready again now that none remain.
  • Thread 14. SH-1's acceptance carries the Axum HTTP client exception.
  • Thread 15. The RC-unit notes name their checked baseline (the RC tag) and each unit PR's head for the re-check before posting.
  • Thread 18. ID-5's acceptance is per capability, with Spin following DEC-14.
  • Thread 23. The DEC-5, DEC-6, DEC-8 and DEC-11 gates are back in the ticket cells. A script that checks every "Blocks ..." list against the plan rows printed 0 mismatches.
  • Thread 35. Task 1 checks each issue's expected parent, moves it with replaceParent:true, and verifies the new parent.
  • Thread 36. WB-3 skips the write only when <name>_cst is also consistent, and re-sets just the companion when it is not.

This head also carries be563274c, which moved IABTechLab/edgezero#397, IABTechLab/edgezero#410, IABTechLab/edgezero#432, IABTechLab/edgezero#437 and IABTechLab/edgezero#438 under IABTechLab/edgezero#468 at the maintainer's request.

The stand-alone script still finds no Fastly or Axum item with a Cloudflare or Spin blocker (69 items).

Validation, docs gates only: Prettier check exit 0, All matched files use Prettier code style!; ts dev lint domains --staged --verbose exit 0.

Next actor: REVIEWER.

Record in the spec's goals, rollout and DEC-4 that Fastly and Axum are the MVP and Cloudflare and Spin follow it, and mark waves 0 to 10 and their tickets as MVP in the plan.
@aram356

aram356 commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator Author

CREATOR: The head moved to 5c3181c6b before round 3 started. The change records a maintainer decision: Fastly and Axum are the MVP, and Cloudflare and Spin follow it. This touches the spec's goal 2, the rollout section and DEC-4, plus the plan's wave summary and the Part B intro, which marks waves 0 to 10 as MVP and lists the post-MVP tickets. Nothing else changed since 0a579977b.

Validation, docs gates only: Prettier check exit 0, All matched files use Prettier code style!; ts dev lint domains --staged --verbose exit 0.

Next actor: REVIEWER, at 5c3181c6b.

Remove the scope exclusion and the related issue note from the spec and plan, and reuse the DEC-2 slot for the MVP decision: Fastly and Axum are the MVP.
@aram356

aram356 commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator Author

CREATOR: The head moved to fbdfbedef before round 3 started. At the maintainer's direction, the spec and plan no longer reference work outside this plan: the scope exclusion and the related issue note are gone. DEC-2 now records the MVP decision: Fastly and Axum are the MVP (waves 0 to 10). Nothing else changed since 5c3181c6b.

Validation, docs gates only: Prettier check exit 0, All matched files use Prettier code style!; ts dev lint domains --staged --verbose exit 0.

Next actor: REVIEWER, at fbdfbedef.

@aram356 aram356 left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REVIEWER: REQUEST_CHANGES — GitHub blocked the formal event: HTTP 422, "Review Can not request changes on your own pull request". Both logins are aram356; this COMMENT preserves the intended verdict and both inline findings.

Round-3 spec/plan review at fbdfbedef5d04634644dff4d9e87eb847f6f500a, base 598a8517072c52690a6b1833e8797d9003f3dba5. Acting REVIEWER and PR author are both aram356 (one-account mode).

All eight previously open findings are substantively corrected and independently accepted/resolved. The 28 earlier resolutions remain intact: all 36 prior findings are resolved. One new should-fix inline finding identifies unqualified GitHub CLI lookups in the cross-repository execution plan. The corrected parent guards do not supply the missing repository selection.

I read both complete documents, the full PR diff and all fixing deltas (7cb8933 to 0a57997 to 5c3181c to this head), all review submissions and thread replies, the new CREATOR handoff, the linked epic criteria and current checks. Separate read-only plan-order and coverage passes confirmed the MVP classification, restored decision gates, RC-unit SHA prefixes and expected parent relations. The final delta replaces the old DEC-2 exclusion with the MVP definition and removes its stale exclusion text. Totals reconcile to Trusted Server 17 existing + 8 Axum + 18 other = 43 and EdgeZero 9 existing + 17 new = 26. Fastly and Axum remain the MVP, with later-platform work explicitly separated.

The eight accepted dispositions this round:

Original thread Subject Disposition
1 Fallback clock Accepted; resolved
7 Review log Accepted; resolved
14 Axum HTTP acceptance Accepted; resolved
15 RC checked baseline Accepted; resolved
18 Spin acceptance Accepted; resolved
23 Decision gates Accepted; resolved
35 Reparenting logic Accepted; resolved
36 SharedID companion acceptance Accepted; resolved

The previous review contains the per-thread URLs and accepted decisions for the other 28 findings. This review adds no duplicate of those findings.

Independent verification at this exact head, in a detached reviewer worktree through prf_run, follows the user's standing instruction: "Yes—docs checks only; submit now". No local runtime/build/full CI suite was rerun. Existing reviewer-installed Prettier and domain-linter executables were reused; this PR changes only the two Markdown files.

/Users/ag/projects/iab/trusted-server/.worktrees/review-1559-e60213f/docs/node_modules/.bin/prettier --config docs/.prettierrc --check docs/superpowers/plans/2026-11-11-server-side-identity-all-adapters.md docs/superpowers/specs/2026-11-11-server-side-identity-all-adapters-design.md — exit 0:

Checking formatting...
All matched files use Prettier code style!

/Users/ag/projects/iab/trusted-server/.worktrees/review-1559-e60213f/target/aarch64-apple-darwin/debug/ts dev lint domains --changed-vs 598a8517072c52690a6b1833e8797d9003f3dba5 --verbose — exit 0:

scanned 586 lines in docs/superpowers/plans/2026-11-11-server-side-identity-all-adapters.md
scanned 537 lines in docs/superpowers/specs/2026-11-11-server-side-identity-all-adapters-design.md

git diff --check 598a8517072c52690a6b1833e8797d9003f3dba5...HEAD — exit 0:

(no output)

python3 /tmp/prfection-1559-r2/check-links.py — exit 0:

Relative Markdown links and anchors: 5 checked, 0 broken

Read-only reproduction for the new plan finding, from the Trusted Server checkout, all exit 0:

gh repo view --json nameWithOwner
{"nameWithOwner":"IABTechLab/trusted-server"}
gh issue view 468 --json id,url,title
{"id":"PR_kwDOOKz8as7JPajI","title":"Redact secrets from logs and downgrade PII log levels","url":"https://github.com/IABTechLab/trusted-server/pull/468"}
gh issue view 468 --repo IABTechLab/edgezero --json id,url,title
{"id":"I_kwDOPsbsO88AAAABei6lQg","title":"Platform capabilities for server-side identity on every adapter","url":"https://github.com/IABTechLab/edgezero/issues/468"}

GitHub Actions readback at this head shows CodeQL Advanced, Integration Tests, Worker auction deadline runtime regressions, Run Format and Run Tests queued; those are pending CI runs, not passing local checks. I did not wait for the full matrix under the user-approved docs-only scope.

No plan task, issue move or cross-PR comment was executed. Next actor: CREATOR. Qualify the repository in the issue/PR lookups, record this review, and provide a new head. The standing design/decision approvals and merge-readiness gates remain; this is not an approval.

@aram356
aram356 marked this pull request as draft November 12, 2026 15:53
Reverse the provider stack to #1487, #1488, #1489 and refresh the moved
heads. Split the EdgeZero release so Axum serving does not wait for the
record contract (R1b), add the ClientInfo contract (EZI-3) and JA4
(IABTechLab/edgezero#283) that ID-7 needs on Axum, and move the Axum side
of providers, abuse protection and SharedID write-back into A10 so Fastly
no longer waits on the Axum chain. Drop blockers that code at the PR heads
shows are already met (#1189, #1556, #1141 before A1), move four-adapter
and decision-gated issues out of the MVP, and align priorities and sizes.
The MVP is now waves 0 to 9.
@aram356

aram356 commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator Author

CREATOR: Head moved from fbdfbedef to ba106e554, on top of the main merge df5650948. This is a ticket audit of order, priority, size and MVP need, with each blocker checked against code at the PR heads. The spec changes are in its review log; the plan changes are below.

Order

Blockers removed, each checked in code

Priority

Size

MVP

Considered and left unchanged

Verification: a script over Part A and Part B reports no problems: order, Blocks mirrored by Blocked-by, no ticket less urgent than what it blocks, and wave priorities matching Part B. Decision gates match between spec and plan in both directions. Prettier and the domain lint pass on the changed lines. These are docs-only changes, so no cargo gates ran.

Each Axum task keeps its own in-memory counter and divides every limit by
the configured task count, so the MVP needs no shared counter (DEC-11).
EZI-5 no longer waits on a decision and shrinks to S. The open remainder,
keys, task count and the Cloudflare and Spin backends, moves to DEC-15.
@aram356

aram356 commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator Author

CREATOR: Head moved from ba106e554 to 5f09873c8. The user decided the Axum half of DEC-11: each Axum task keeps its own in-memory counter and enforces each limit divided by the configured task count, and the MVP has no shared counter. The changes:

  • ID-6's Accept changes from two tasks sharing one counter to an Axum task configured for two tasks refusing at half the limit.
  • EZI-5 is Fastly Edge Rate Limiting plus an in-memory Axum backend, no longer waits on a decision, and shrinks from M to S. It is the first decision gate cleared off R2's path.
  • The open remainder (keys, the Axum task count, and the Cloudflare and Spin limiter backends) is new DEC-15. It gates T10, A7, EZI-5c, EZI-5s and Collect server-side identity provider EIDs in a single page-load write #1487's key item.

The ticket checker and the decision-gate cross-check both pass, as do Prettier and the domain lint on the changed lines.

This was referenced Nov 13, 2026
@aram356

aram356 commented Nov 13, 2026

Copy link
Copy Markdown
Collaborator Author

CREATOR: The plan's Tasks 1 to 8 ran from the approved head c7dc9de77, before this PR merged, at the user's direct instruction (merging waits for an approval from another account). Every write was rendered in a dry run first, executed from that dry run, and read back.

Found during Task 2's duplicate search and not yet in the plan: #1547 (no-match lookups are re-sent on every navigation, a #1487 follow-up like #1553 and #1551) and IABTechLab/edgezero#436 (the issue #275 closes). Both are proposed for a follow-up plan amendment.

#1567 is the story PRs #1487, #1488 and #1489 deliver, so it takes #1246's place under #1558. It moves to wave 5, after #1489, and the provider-stack tie-out and Part C items now name it.
Both repositories now keep an integration branch named rc/identity, and the
user ruled out tags, so AX-7, EZI-6 and DEC-5 describe integration points as
commits pinned by SHA, and DEC-20 records Trusted Server's own branch. The
spec gains an Integration branches section with what each branch carries and
which included heads moved since. ID-7's State notes that EdgeZero pull
request 469 reads Axum's JA4 from a trusted proxy header, and EZI-2b's celld
work now waits on EdgeZero pull request 422, which absorbed closed 463.

The plan gains a State section for 2026-11-15, marks Tasks 1 to 8 as run,
retires wave 1's fallback and the fold-in, renames R1 to R4 as
integration-branch revisions, lists the issues moved or filed after the run,
and aligns #1567's size with the board. The review log records round 8, the
plan run and this refresh.
…ity plan

Both integration branches now carry every in-review issue's non-draft pull
request. DEC-20 records the new rule that a conflict is fixed in the pull
request that lands second, and DEC-21 the merge order the user chose: the
Trusted Server pull requests stack linearly on #1506 (stack 1621), so T1,
#1525 and #1526 land after the cutover. The spec's Integration branches
section and the plan's State section list the new heads, and the wave rows
for T1, #1525, #1526, #1506 and #1487 follow the new order.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant