Repository navigation
Conversation
3 tasks
…al before writes The Fastly runner now uses the production native request read and prepare, replacing only the client IP, geo result and JA4-backed device signals that Viceroy cannot supply. Refused scenarios must stop before any write attempt, with a native control proving the check rejects one. Docs describe the failed-geo fixture and record current progress.
prk-Jr
marked this pull request as ready for review
November 17, 2026 05:28
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ts-ec) without its stored record, and never drops an existing identity when geo is unavailable.This PR adds tests and test infrastructure only. It changes no production identity behavior and adds identity to no other adapter.
Stacked on #1506 (
spec/edgezero-pr275-migration, baselinecc811fc7aa0d234e447a868af5b8ab4ea359326a). Retarget tomainafter the cutover merges.Changes
.github/workflows/test.ymlcrates/trusted-server-adapter-fastly/src/identity_conformance.rscrates/trusted-server-adapter-fastly/src/main.rscrates/trusted-server-adapter-fastly/src/platform.rscrates/trusted-server-core/src/ec/kv_backend.rstest/test-utilsgates.crates/trusted-server-core/src/test_support.rscrates/trusted-server-core/src/test_support/identity_conformance.rscrates/trusted-server-integration-tests/README.mddocs/superpowers/specs/2026-11-16-identity-conformance-design.mddocs/superpowers/plans/2026-11-16-identity-conformance.mdscripts/test-identity-conformance.mjsscripts/test-identity-conformance.test.mjsCloses
Does not close an issue. This is the first slice of #1586, which cannot close until other planned work lands.
#1586 asks for three things. Where each one stands:
ec.ec_storeinstead would break startup for existing Axum, Cloudflare and Spin configs.Order of the remaining work: #1506 → #1600 → #1574, then the startup check and the SH-5 check. Cloudflare follows in #1588.
Spec
Spec: Identity conformance design
Plan: Identity conformance implementation plan
Both documents include two review rounds. The missing-browser-metadata scenario reflects today's browser gate and must change when #1592 permits absent JA4.
What the suite does not cover
Test plan
Local checks use Rust 1.98.1, Node 24.20.0 and Viceroy 0.21.0.
cargo test-fastly && cargo test-fastly-reuse && cargo test-axum && cargo test-cloudflare && cargo test-spincargo clippy-cli && cargo clippy-codegencargo fmt --all -- --checkNegative controls. Disconnecting finalization made the suite fail the missing-cookie check. Treating missing geo as consent withdrawal made it fail at "should retain the reader's cookie". Both pass again when restored. Native controls also reject late writes, late failures, expired cookies and tombstones counted as live records.
Headless Chrome. Real Chrome through the local hostname proxy to the publisher page, with
us_privacy=1YNN(Viceroy's default location is a US state that needs a consent signal):ts-ec; consent allowed, refused at the bot gate (ja4=None)ts-ecand a live record for the same IDSec-GPC: 1)The test build differs from the reviewed code only by a one-line fixed JA4 fallback, so this proves the lifecycle mechanics, not the real production ingress. Server-side DataDome protection was disabled in the disposable local config, protected image assets were blocked, and only the HTML document was checked.
The supplemental native core
--all-targets --features test-utilsclippy run reports the pre-existingresult_large_errlint inrun_pre_dispatch_hook, reproduced on the unchanged cutover base. This PR does not touch it.Checklist
unwrap()in production codelogmacros (notprintln!)