Repository navigation
Conversation
Axum now builds the partner registry and both provider coordinators at startup, reads and mints ts-ec on publisher navigations, runs page-phase lookups through Axum's HTTP client, and finalizes through KvIdentityGraph with a single page-load write. After-response providers run on a spawned blocking task with their follow-up compare-and-swap write. The identity graph is a process-local store with generation-based CAS, enabled when ec.ec_store is set. Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
3 tasks
prk-Jr
changed the base branch from
feat/s2s-eid-vendors
to
feat/axum-identity-providers
November 18, 2026 15:19
prk-Jr
force-pushed
the
fix/1555-provider-eid-opt-outs
branch
from
November 18, 2026 15:19
7ac8b5e to
ee7a110
Compare
prk-Jr
changed the base branch from
feat/axum-identity-providers
to
feat/1574-axum-shared-identity
November 20, 2026 09:49
prk-Jr
marked this pull request as ready for review
November 20, 2026 10:24
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stack and refresh
Base:
feat/1574-axum-shared-identity(#1646), headc054ece709457dd4420aac27ccbb40c57e8c1cb0. This includes #1566 (240149789), and through #1646 this PR depends on #1641, #1635, #1613 and #1637; #1624 supplies SharedID write-back earlier in the identity stack.Signed merge
d72c8bb37f4133bc81074270feb2cc28a10c88f3directly merges #1646 into the existing #1626 headee7a11031. No separate #1566 merge, rebase or force-push. The new merge is locally verified and GitHub Verified. No dependency branch was modified.Whenever #1646 changes during review, merge its new head into this branch and revalidate the affected behavior before readiness.
Merge resolutions
Cargo.lockCargo.tomlapp.rsIdentityApplifecycle and prepared record binding.lib.rsmiddleware.rsapp.rschecked_app_config.rsauction/endpoints.rsec/eids.rsec/identify.rsec/pull_sync.rspublisher.rsapi-reference.mdaxum-dev.mdconfiguration.mdRemoved Axum
identity.rs,ec_kv.rsand their obsolete test module stay removed. The former EC policy-only flag is also unnecessary: #1646 deliberately keeps the configured record graph available without recognized fingerprint metadata.Changes
pubcid.organdsharedid.org), closing opposite-alias/trailing-dot bypasses. Existing source-specific consent and write ownership remain unchanged.All #1555 acceptance criteria are implemented here. Shared lifecycle/provider activation belongs to #1646, write-back to #1624, record binding to #1641, prepared startup to #1635, bounded follow-up work to #1613, and the environment guard to #1637.
Closes
Closes #1555
Spec
Not a feature: bug fix, with no configuration or persisted-schema change.
Design and plan.
An opt-out applies while its deadline is strictly greater than the request time and an enabled owner claims the source. Client EIDs cannot clear active memory. Missing, failed or mismatched snapshots retain existing degraded behavior. Legacy expiry is read-time suppression; rollback can resume serving old singles.
Geo and native startup
Axum production verification uses
geo-cloudfront, prepared config/secret stores, isolated persistent records, an admitted loopback peer, the existing protected-origin credential/header mechanism, checked forwarding metadata and countryAU, following the native acceptance setup. Geo selection uses supported EdgeZero startup options. No runtime environment reads were added, and the legacyTRUSTED_SERVER_CONFIG_*/TRUSTED_SERVER_SECRET_*bridge is not used for feature activation.The default geo-off configuration still has unknown jurisdiction and fails identity use closed. The earlier claim that the native executable has no usable geo capability is obsolete: the configured protected-country production path now runs successfully. Migration of the pre-existing narrowly guarded geo profile compatibility input remains owned by #1529/#1532.
Test plan
Local checks passed on the merged source tree committed as
d72c8bb37; Rust 1.98.1, Node 24.20.0 and isolated stock Viceroy 0.21.0. Release artifacts omit debug symbols.cargo test-fastly: 239 adapter tests and 3,781 core tests passed; provider/JS/OpenRTB and documentation tests also passed.cargo test-fastly-reuse: 239 adapter tests passed.cargo test-axum --features geo-cloudfront: 119 tests passed, including the new prepared-store executable regression.cargo clippy-fastlyandcargo clippy-axum.ee7a11031: no-provider cookie/body/initial/page-bids, repeated remembered-policy suppression and expired-memory delivery. Its strict JA4 gate under stock Viceroy prevents qualifying creation/provider transitions or positive stored-ID enrichment; those controls are not claimed.d72c8bb37: all 29 checks and all six workflows completed successfully. No failures or reruns.Remembered server state is explicitly fixture-seeded: native uses a typed
KvEntry, the production record adapter and exact-generation conditional write while the process is stopped; Fastly uses equivalent valid manifest state. Subsequent reads, filtering and cookie opt-back-in execute the normal release binaries. These results do not establish an HTTPS vendor response creating that memory, live-vendor behavior, deployed-edge behavior or real-browser behavior.Hosted CI results
Every check below passed on
d72c8bb37f4133bc81074270feb2cc28a10c88f3against basec054ece709457dd4420aac27ccbb40c57e8c1cb0. All six workflows completed; no failures or reruns.Independent final source/evidence checks found zero blocking code findings and zero optional findings. Code review and CI are clear. Overall requested qualification remains blocked on the HTTPS producer transition described below; no review comments or replies were posted.
Draft and remaining qualification
Keep Draft for the outstanding requested HTTPS provider-response-to-persisted-memory runtime qualification. Code review, all local checks and all hosted checks are clear. The earlier merge-conflict and configured-native-geo blockers are resolved. This still depends on open #1646 and its stack; that dependency must land first.
The requested full provider-response-to-memory runtime qualification remains unverified. Native EdgeZero's production transport has no supported per-process fixture CA/routing override, and the current Fastly transport rejects predeclared backend-name collisions, preventing the old plaintext remap technique. No SDK guard or system trust setting was weakened. A supported local HTTPS fixture/trust/routing facility belongs in EdgeZero; no EdgeZero implementation was added here. See the pinned native transport and Fastly backend ownership handling. Broader provider/browser qualification remains tracked by #1581.
Checklist
Runtime artifact receipts
Release artifacts were built with Rust 1.98.1 and Node 24.20.0, with debug symbols omitted. Both refreshed runtimes passed 28 bidder assertions plus the explicit seeded-memory receipt; the pre-refresh control passed 14 bidder assertions within its stated scope.
geo-cloudfrontdc6abc25fcd17ae55b0bc7abef101aa2ac81045970174568b9a77ed86f61777816fab5296b5994d62e8c96df0b1f887d22589ad4d4297b298e57a148f4597fe7ee7a11031Fastly control3d097e426db136cd6879ba6eabf7d2818e278586f7b5ce74edd525e6937dda4d