Skip to content

Test: Extract User VO and Batch Name Lookup (Trunk) - #12451

Open
thojou wants to merge 1 commit into
ILIAS-eLearning:trunkfrom
thojou:bugfix/13/45372-2
Open

thojou wants to merge 1 commit into
ILIAS-eLearning:trunkfrom
thojou:bugfix/13/45372-2

Conversation

@thojou

@thojou thojou commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Original: #11514

See: https://mantis.ilias.de/view.php?id=45372

After importing test users to another system, participant rows could still show wrong names because views used global user lookups or generic anonymous labels instead of test-local metadata. Resolving names via getParticipantByActiveId() per row also duplicated heavy participant queries in lists and tables.

Introduced ILIAS\Test\Participants\User with identity fields and getDisplayName(), wired it through Participant, and added ParticipantRepository::getUsersByActiveIds() as a lightweight batched lookup against tst_active and usr_data. The method returns a \Generator keyed by active id, consistent with getParticipants(). Updated evaluation, toplist, manual scoring, and participant list call sites to batch-fetch users and use getUser() for user-facing data.

(cherry picked from commit eb7c9dd)

@thojou thojou self-assigned this Nov 19, 2026
@thojou thojou added bugfix php Pull requests that update Php code labels Nov 19, 2026
See: https://mantis.ilias.de/view.php?id=45372

After importing test users to another system, participant rows could still
show wrong names because views used global user lookups or generic anonymous
labels instead of test-local metadata. Resolving names via
`getParticipantByActiveId()` per row also duplicated heavy participant queries
in lists and tables.

Introduced `ILIAS\Test\Participants\User` with identity fields and
`getDisplayName()`, wired it through `Participant`, and added
`ParticipantRepository::getUsersByActiveIds()` as a lightweight batched
lookup against `tst_active` and `usr_data`. The method returns a
`\Generator` keyed by active id, consistent with `getParticipants()`. Updated
evaluation, toplist, manual scoring, and participant list call sites to
batch-fetch users and use `getUser()` for user-facing data.

(cherry picked from commit eb7c9dd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix php Pull requests that update Php code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants