Skip to content

48553: [LTI] send the LTI calls through the proxy of ILIAS - #12456

Merged
Saaweel merged 1 commit into
ILIAS-eLearning:trunkfrom
surlabs:trunk_LTI_fix_proxy
Nov 19, 2026
Merged

Saaweel merged 1 commit into
ILIAS-eLearning:trunkfrom
surlabs:trunk_LTI_fix_proxy

Conversation

@Saaweel

@Saaweel Saaweel commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Mantis: https://mantis.ilias.de/view.php?id=48553

The LTI component does not use the proxy configured in ILIAS. celtic/lti sends its calls (key sets of platforms and tools, access tokens, Names and Role Provisioning Services, Assignment and Grade Services) with its own cURL client, which does not know the proxy settings of ILIAS. On servers that can only reach other hosts through that proxy, launches are refused with "JWT signature check failed" and grades are not sent.

Fix

  • New ilLTICurlClient sends the calls of celtic/lti with ilCurlConnection, which applies the proxy settings of ILIAS like the other calls of ILIAS.
  • ilLTILibraryLogger uses it only when the proxy of ILIAS is active. Without a proxy nothing changes: the library keeps its own client, which still follows the proxy settings of the environment of the server.
  • Calls over plain HTTP are handed to the proxy without a tunnel, as many proxies only open tunnels to port 443.
  • When a call gets no answer at all, ilLTIHttpClient logs a warning with the cause (for example, that the proxy cannot be reached), which the library otherwise only reports as a failed signature or service call.

Testing

With the proxy of ILIAS pointing to a proxy that only opens tunnels to port 443, every call went through the proxy: launch, Names and Role Provisioning Services, grades on launch and by the cron job, deep linking as tool and as platform, and the token endpoint. With the proxy active but not reachable, the launch is refused and the log shows the warning with the cause. Without a proxy, everything works as before and no call goes to the proxy. ilLTICurlClientTest covers a call through a proxy that cannot be reached.

@Saaweel Saaweel added bugfix php Pull requests that update Php code labels Nov 19, 2026
@Saaweel Saaweel self-assigned this Nov 19, 2026
@Saaweel
Saaweel merged commit 3b38373 into ILIAS-eLearning:trunk Nov 19, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix php Pull requests that update Php code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant