Repository navigation
test(coverage): include igx-templates and cover lines touched by strict mode - #1850
Draft
ivanvpetrov wants to merge 1 commit into
Draft
ivanvpetrov wants to merge 1 commit into
ivanvpetrov wants to merge 1 commit into
Conversation
…ct mode - stop excluding packages/igx-templates from nyc (keep its files/ dirs excluded) - add specs for the custom grid, tree grid, hierarchical grid, multi-column headers and calendar templates - add specs for IgniteUIForReactTemplate.generateConfig - cover the list "Views" group, failed npm install on upgrade and cli-config workspace read errors
ivanvpetrov
added this pull request to stack #1851
October 20, 2026 13:32
11 of 16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prepares for enabling TypeScript strict mode (#1613) by testing the code the strict-mode fixes will touch.
Of the strict compiler errors outside
spec/, 37 were on lines no test ran:packages/igx-templatescli,coreandng-schematicsAfter this PR, every strict-mode error is on a line the tests run, on a line with no runtime code, or in a file excluded from coverage.
Coverage config
packages/igx-templates/has been innyc.excludesince test(coverage): include files for coverage, update path to schematic specs #567 (2019), so its coverage was never reported. Only its**/files/template folders are excluded now.New specs
IgniteUIForReactTemplate.generateConfig: base variables, merging of extra configuration, and the widget and description variables.Extra cases in existing specs
list: custom view templates are grouped under "Views".upgrade: a failednpm installis reported, and the "installed" message is not logged.cli-config(ng-schematics): a malformedangular.jsonis rethrown as a plain error.Coverage (local nyc run)
packages/igx-templatesaloneRelated Issue
Part of #1613
Type of Change
Affected Packages
igniteui-cli(packages/cli)@igniteui/cli-core(packages/core)@igniteui/angular-templates(packages/igx-templates)@igniteui/angular-schematics(packages/ng-schematics)@igniteui/mcp-server(packages/igniteui-mcp)Checklist
npm run test)npm run build)npm run lint)Additional Context
This is the second of three stacked PRs for #1613. It is based on #1849 (bug fixes) and should be merged after it. The next PR enables
"strict": trueand fixes the compiler errors.Only tests and the nyc config change; there are no source changes. The packages ticked above are the ones whose code the new tests cover.