Repository navigation
Trim eltype conversions in the operator test helpers - #709
Merged
Merged
Conversation
Each eltype conversion recompiles the operator algebra for the new eltype, which dominated the compilation time of the PDE tests downstream. Drop the Float32 and ComplexF32 conversions, and only test the conversion to ComplexF64 for operators on 1D domains. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #709 +/- ##
==========================================
+ Coverage 75.20% 76.41% +1.21%
==========================================
Files 79 81 +2
Lines 8445 8752 +307
==========================================
+ Hits 6351 6688 +337
+ Misses 2094 2064 -30 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testinfoperatorandtestfunctionalrun their checks on the operator itself and again on converted copies. Each conversion recompiles the operator algebra for the new eltype. For 2D operators (Kronecker products, block-banded caches), that dominates compile time in the downstream PDE tests.This PR:
Float32andComplexF32conversionsComplexF64only for operators on 1D domainstestfunctional, re-tests atFloat64only if the operator isn't alreadyFloat64, astestinfoperatoralready didTiming for
ApproxFunOrthogonalPolynomials/test/PDETest.jl, run alone in a fresh session (Julia 1.13):The test count falls because the removed conversions each re-ran the full set of checks.
Tested locally: the ApproxFunBase test suite and the ApproxFunOrthogonalPolynomials test suite both pass against this branch.
🤖 Generated with Claude Code