Repository navigation
Add a history_key keyword to keep separate test histories - #189
Merged
Merged
Conversation
giordano
force-pushed
the
mg/history-key
branch
from
September 20, 2026 09:17
f5da21f to
d98e5e5
Compare
christiangnrd
approved these changes
Sep 20, 2026
christiangnrd
left a comment
christiangnrd
left a comment
Collaborator
There was a problem hiding this comment.
I like this a lot and Metal.jl already has a use for this with its shader validation pass.
giordano
force-pushed
the
mg/history-key
branch
from
September 20, 2026 12:47
d98e5e5 to
974add8
Compare
stacked auto-merge was automatically disabled
September 20, 2026 17:42
Pull Request is not mergeable
stacked auto-merge was automatically disabled
September 20, 2026 17:46
Pull Request is not mergeable
Collaborator
Author
|
Sigh, Github messed up the stack...... |
Collaborator
Author
|
And the conflicts can't be resolved in the web interface. This branch had one commit on top of the other one, how hard it'd be to rebase it?! OK, I'll have to resolve this when I'm home |
All runs of a package on a machine share one history of durations and failures, keyed only by the module name and the Julia minor version. When the same suite runs in configurations with different timings, for instance on a CPU and on a GPU in separate CI jobs of one agent, each run reorders the tests using the other's measurements. `runtests(...; history_key = "gpu")` stores the history in `<mod>-gpu.jls` next to the default file, which stays as it is when the keyword is omitted. Fixes #187 (second proposal). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TNK7qXSraxSfzK6T4UxUtk
Collaborator
Collaborator
Author
|
If you can push, that'd be great! I won't be home for about an hour at least |
christiangnrd
force-pushed
the
mg/history-key
branch
from
September 20, 2026 19:05
974add8 to
5daa1bb
Compare
Collaborator
Author
|
I'm going to tag a new version, so that I can use this in Oceananigans. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #187.