Repository navigation
fix(environment): raise FileNotFoundError instead of silently loading nothing #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
boring877
wants to merge
1
commit into
K0lb3:master
Choose a base branch
from
boring877:fix/silent-empty-environment-on-missing-path
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| import pytest | ||
|
|
||
| import UnityPy | ||
|
|
||
|
|
||
| def test_load_missing_file_raises(): | ||
| # silently returning an empty Environment hides typos and wrong paths | ||
| with pytest.raises(FileNotFoundError): | ||
| UnityPy.load("definitely_missing_file.unity3d") | ||
|
|
||
|
|
||
| def test_load_missing_dependency_stays_silent(): | ||
| # missing dependencies (e.g. unshipped externals) are normal and must be skipped | ||
| env = UnityPy.Environment() | ||
| assert env.load_file("no_such_dependency.assets", is_dependency=True) is None | ||
|
|
||
|
|
||
| def test_load_folder_still_works(tmp_path): | ||
| (tmp_path / "dummy.asset").write_bytes(b"not a real unity file, just needs to exist") | ||
| env = UnityPy.load(str(tmp_path)) | ||
| assert len(env.files) == 1 | ||
|
|
||
|
|
||
| def test_load_bytes_still_works(): | ||
| env = UnityPy.load(b"UnityFS\x00") | ||
| assert len(env.files) == 1 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually,
this should always be an exception,
as the prior code already checks if the arg is a str and if it's a file or folder.
Therefore, if both are wrong, the argument can't be loaded anyway on this branch.