Repository navigation
Normalize UNorm/SNorm vertex channels in MeshHandler - #401
Open
1915rising wants to merge 1 commit into
Open
1915rising wants to merge 1 commit into
1915rising wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #387.
MeshHandler.read_vertex_data returned normalized vertex channels as raw integers: a UNorm8 colour came back (255, 128, 0, 255) instead of (1.0, 0.502, 0.0, 1.0), and UNorm16 UVs exported to OBJ as vt 65535 32768. The compressed-mesh and copy_from_mesh paths already normalize, so the result depended on how the mesh was stored.
This normalizes channel data at unpack time (UNorm by format max, SNorm by signed max clamped to -1.0), across the legacy, 2017 and 2019+ format layouts and both the Python and UnityPyBoost unpack paths, matching the existing in-repo behaviour.
Tests: new parametrized regression tests in tests/test_mesh_helper.py pass (2 passed). The 3 remaining failures in that file are pre-existing and identical before/after: they need Git LFS sample files that are not fetched in my environment. Broader suite after the change: 39 passed, 4 failed, all four being the same LFS sample-data failures.