Repository navigation
V2: resolve a Wildcard UCC product when the wildcard is only in the SANs (EMS-1173) - #46
Merged
spbsoluble merged 2 commits intoNov 17, 2026
Conversation
…ildcard CN A DV/OV request with CN = apex and SAN = *.apex failed with EMS-1173: the wrapper keys "wildcard" on certificate.domain alone and resolved a plain UCC product. Sending the wildcard as the domain is rejected too (EMS-1056, the domain must match the CSR CN). Both confirmed live. With no template ProductCode, the plugin now reads the catalog and sends the account's single active Wildcard UCC product (typeID 21 DV / 22 OV) as X-Product-Code. No match, several matches, a catalog failure, or EV fails before any order is placed, asking for ProductCode. Adds unit coverage and an opt-in live probe (CERTINEXT_V2_WILDCARD_SAN_PROBE).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
EMS-1173 Invalid Additional Domain Namesfor a V2 DV or OV request whose CN is a plain name and whose SANs include a wildcard (CNexample.com, SAN*.example.com).Fixes
certificate.domainstarts with*..EMS-1056).ProductCode, it reads the catalog once.X-Product-Code(type 21 for DV, 22 for OV).ProductCode, if there's no matching product, more than one, the catalog can't be read, or the order is EV.ProductCodeis used as before, with no lookup.Testing
V2ProductCodeResolutionTests; all 1358 pass.V2WildcardSanShapeTests(CERTINEXT_V2_WILDCARD_SAN_PROBE=1), plus a read-only catalog dump.Other