Skip to content

fix(volume-rendering): fit Shift and Width slider steps to the color range - #1031

Open
PaulHax wants to merge 2 commits into
volume-opacity-histogram-rangefrom
volume-mapping-range-sliders
Open

PaulHax wants to merge 2 commits into
volume-opacity-histogram-rangefrom
volume-mapping-range-sliders

Conversation

@PaulHax

@PaulHax PaulHax commented Nov 13, 2026

Copy link
Copy Markdown
Collaborator

Builds on #1030. Part of the series replacing #1003.

The Shift and Width sliders took their step from the image data range and Width had a fixed minimum of 1. For data narrower than 1, such as normalized floats, Width was pinned and could not narrow the range, and Shift showed a nonzero value when unshifted.

Step and bounds now come from the full color range: the step is at most 1/256 of it, Width starts at one step, and Shift bounds are whole steps either side of zero. Integer ranges keep a step of 1.

@PaulHax
PaulHax force-pushed the volume-mapping-range-sliders branch from 1958750 to 864a72d Compare November 13, 2026 03:53
@PaulHax
PaulHax force-pushed the volume-mapping-range-sliders branch from 864a72d to 000b9d9 Compare November 13, 2026 15:26
@PaulHax
PaulHax force-pushed the volume-mapping-range-sliders branch from 000b9d9 to 512204d Compare November 14, 2026 20:17
…range

Derive the slider step and bounds from the full mapping range rather than
the image data range and a fixed Width minimum of 1, so normalized and
narrow float volumes and volumes with far outliers can be edited, and an
unshifted range sits on the Shift slider grid.
@PaulHax
PaulHax force-pushed the volume-mapping-range-sliders branch from 512204d to c823c05 Compare November 15, 2026 09:33
@PaulHax
PaulHax added this pull request to stack #1036 November 15, 2026 16:55
@netlify

netlify Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for volview-dev ready!

Name Link
🔨 Latest commit c823c05
🔍 Latest deploy log https://app.netlify.com/projects/volview-dev/deploys/6af9e40de3fb404e712f00f6
😎 Deploy Preview https://deploy-preview-1031--volview-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant