Repository navigation
fix: preserve camera settings across image switches - #1032
Merged
Merged
Conversation
✅ Deploy Preview for volview-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
PaulHax
force-pushed
the
camera-config-image-switch
branch
from
November 13, 2026 03:13
71350c4 to
4e01383
Compare
PaulHax
force-pushed
the
camera-config-image-switch
branch
from
November 13, 2026 14:12
4e01383 to
2bdabb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching a view to another image could leave that image without a saved zoom. The camera and its per-image settings were linked once, and a value was only saved when it changed. Two images of the same size fit the view at the same zoom, so nothing was stored for the second image when it was first shown.
The link is now rebuilt whenever the view or its image changes, so the current camera is saved for the new image even when it is unchanged. It waits until the view has fitted its camera to the new image, so an image that is still loading in the en face view is not saved with the previous image's camera.
Example
With two images of the same dimensions and spacing loaded:
Before this change the second image appears at the first image's zoom, although it was never zoomed. With this change it returns to the fitted view it had in step 1.
Split out of #1015, where it was unrelated to the segment changes.