Skip to content

fix: preserve camera settings across image switches - #1032

Merged
PaulHax merged 1 commit into
Kitware:mainfrom
PaulHax:camera-config-image-switch
Nov 13, 2026
Merged

PaulHax merged 1 commit into
Kitware:mainfrom
PaulHax:camera-config-image-switch

Conversation

@PaulHax

@PaulHax PaulHax commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Switching a view to another image could leave that image without a saved zoom. The camera and its per-image settings were linked once, and a value was only saved when it changed. Two images of the same size fit the view at the same zoom, so nothing was stored for the second image when it was first shown.

The link is now rebuilt whenever the view or its image changes, so the current camera is saved for the new image even when it is unchanged. It waits until the view has fitted its camera to the new image, so an image that is still loading in the en face view is not saved with the previous image's camera.

Example

With two images of the same dimensions and spacing loaded:

  1. Click the second image so the active view shows it, fitted to the view.
  2. Click the first image again and zoom in.
  3. Click the second image.

Before this change the second image appears at the first image's zoom, although it was never zoomed. With this change it returns to the fitted view it had in step 1.

Split out of #1015, where it was unrelated to the segment changes.

@netlify

netlify Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for volview-dev ready!

Name Link
🔨 Latest commit 2bdabb5
🔍 Latest deploy log https://app.netlify.com/projects/volview-dev/deploys/6af71ac3da9fb71f8b3b34c6
😎 Deploy Preview https://deploy-preview-1032--volview-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@PaulHax
PaulHax force-pushed the camera-config-image-switch branch from 71350c4 to 4e01383 Compare November 13, 2026 03:13
@PaulHax
PaulHax force-pushed the camera-config-image-switch branch from 4e01383 to 2bdabb5 Compare November 13, 2026 14:12
@PaulHax
PaulHax merged commit 6a5336c into Kitware:main Nov 13, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant