Skip to content

fix(desktop): tidy Settings button hierarchy and titles - #4056

Open
LHagfoss wants to merge 2 commits into
mainfrom
fix/desktop-settings-polish
Open

LHagfoss wants to merge 2 commits into
mainfrom
fix/desktop-settings-polish

Conversation

@LHagfoss

@LHagfoss LHagfoss commented Nov 19, 2026 •

Copy link
Copy Markdown
Owner

What

A pass over every Settings page in the mock (18 pages, plus the right panel, terminal, Needs you, Board and Scheduled Jobs), fixing what was inconsistent rather than restyling. The theme, tokens and layout stay as they are.

  • Button hierarchy. Section header actions were four different things: plain text ("Check all"), ghost ("Add server", "New skill", "New theme"), filled ("Add harness", "Run again") and primary white ("Add machine"). Now they are all size="sm", the action that adds to the section is filled, its companions are quiet, and none is primary. In lists, "Sign in" on an MCP server and "Revoke" on a paired device take the default fill, so a list no longer shows a white pill per row or a button that reads as plain text. "Restart Server" is "Restart server", as on Diagnostics.

  • Two title levels. Usage stacked two equal bold titles (the harness, then the account); Skills styled its source names by hand. Group and SectionTitle take minor for a card inside a titled section: smaller, medium weight, muted.

  • Code in text. Titles and notes showed literal backticks (Put `rustcode` on your PATH, `/login`). withCode in settingsKit sets them in code type; the server-problem banner now uses the same helper instead of its own copy.

  • Outside agents. The hosted agent tiles marked the pick with an accent outline, which the design rules forbid (state is a fill), and the steps sat directly under a separator. The tiles are now told by fill, and the pick, its steps and its action are one padded block.

  • Alignment. Slider rails started at different x positions depending on the length of the value beside them; the value now has one width. The server log starts on the card's 16px line.

  • One arrow circle. Reset, restore defaults, restart, retry, run again and refresh used three different arrow glyphs, and "Restart server" had an icon on one page and none on three. They all draw the same arrow circle now.

  • One restart row. "Restart the server to apply" was written out on three pages; RestartToApply is the one copy.

  • Less repeated text. Usage no longer repeats the reset time beside each harness title.

  • Outside agents picker. The machine picker is the same Showing bar as on the other machine pages.

docs/design.md records the button, title, tile, code and icon rules.

Not changed: the right panel, terminal, Needs you, Board and Scheduled Jobs. I looked at each and found nothing I could improve without changing a deliberate design choice.

Screenshots

Each pair is before / after, with what changed in it underneath.

Outside agents

Before After
before after

Changed: The machine picker is now the same Showing bar as Connections and Voice (it was a loose segmented control under the intro text). The hosted agent tiles mark the pick with a fill instead of an accent outline, and the tiles, the numbered steps and Open in Claude sit in one padded block instead of hanging under a separator.

Usage

Before After
before after

Changed: The account name under each harness ("Paral 2 max", "ChatGPT") is a second-level title instead of a second bold one. The "The soonest window resets in …" caption beside every harness title is gone: each bar already says when it resets, and the page footer still gives the soonest one.

Capabilities

Before After
before after

Changed: Add server and New skill are filled and the same small size as their quiet companions (Edit config, Create with agent); they were ghost text. Sign in on a server is a normal filled button, not a white primary one per row. Skill sources (Project, Shared, Claude Code) use the shared second-level title.

About

Before After
before after

Changed: rustcode in the step titles and notes is set as code instead of showing literal backticks. Run again is the small header size and carries the arrow-circle icon.

Orchestration

Before After
before after

Changed: The restart row is now one shared component on General, Orchestration and Advanced: "Restart server" in sentence case with the arrow-circle icon (it was "Restart Server" with no icon, written out three times). Restore defaults in the header shows the same arrow circle. Slider rails start at the same x in all three rows.

Appearance

Before After
before after

Changed: Restore defaults (top right) uses the arrow circle; it had its own counter-clockwise glyph that matched nothing else. Row reset buttons, the terminal's Restart and Retry buttons now draw the same icon. New theme is filled, like every other section's adding action.

Machines

Before After
before after

Changed: Add machine is a small filled header action, not the page's only white primary button; a section header never holds the primary.

Diagnostics

Before After
before after

Changed: The server log text starts on the card's 16px line, level with the toolbar above it. Restart server here already had the arrow circle; it is now the one every other page uses.

Changelog

Settings: consistent button styles and section titles, commands shown as code, and a cleaner hosted-agent picker.

Testing

  • bun run check in apps/desktop: typecheck, lint, 3082 tests and the build pass.
  • Every Settings page screenshotted before and after in the mock window (dark), after each pass.
  • No Rust changes.

Section header actions share one size and one rule (the adding action filled, companions quiet, none prominent), repeated row actions stop being white pills, and labels are sentence case. Cards inside a titled section take a quieter second title level. Backticked commands in titles and notes render as code. The hosted agent picker is told by fill instead of an accent outline and reads as one block with its steps. Slider rails line up across rows, and the server log starts on the card's 16px line.
@github-actions github-actions Bot added the fix A bug fix label Nov 19, 2026
Second pass: one arrow-circle icon for reset, restart, retry and refresh; one shared restart-to-apply row; Outside agents uses the Showing bar; Usage drops the repeated reset caption.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants