Skip to content

⚡ Bolt: Pre-compile Regex in model importers - #628

Merged
LeanBitLab merged 1 commit into
mainfrom
bolt-regex-precompile-importers-15444921821559476927
Oct 8, 2026
Merged

LeanBitLab merged 1 commit into
mainfrom
bolt-regex-precompile-importers-15444921821559476927

Conversation

@LeanBitLab

Copy link
Copy Markdown
Owner

💡 What: Extracted Regex instantiations in HandwritingModelImporter and TranslationModelImporter out of their local scopes and into companion objects (or object-level private val properties) so they are compiled once at initialization.

🎯 Why: In methods like detectLanguageCode and detectLanguageTag, a new Regex was being allocated and compiled on every invocation, and in TranslationModelImporter this even occurred inside a loop reading ZIP entries.

📊 Expected Impact: Eliminates runtime regex compilation overhead and transient allocations during language detection and importing workflows.

🔬 Verification:

  • assembleStandardDebug succeeded.
  • testStandardDebugUnitTest succeeded.
  • Em dashes checked.

PR created automatically by Jules for task 15444921821559476927 started by @LeanBitLab

Extract Regex instantiations in TranslationModelImporter and HandwritingModelImporter into object-level properties. This prevents runtime re-compilation of regular expressions during language detection and ZIP entry parsing, reducing latency and garbage collection pressure in model importing flows.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@LeanBitLab
LeanBitLab merged commit d481dd3 into main Oct 8, 2026
1 check passed
@LeanBitLab
LeanBitLab deleted the bolt-regex-precompile-importers-15444921821559476927 branch October 8, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant