Repository navigation
fix(compose): use published GHCR images instead of local builds - #86
Merged
Merged
Conversation
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
henmohr
previously approved these changes
Oct 23, 2026
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
henmohr
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app,cronandwebwith prebuilt GHCR images in both standard and Garage S3 Docker Compose deployments.ghcr.io/librecodecoop/nextcloud-docker-app:${NEXTCLOUD_VERSION:-stable-fpm};cronandappuse the same resolved image, with the existing/cron.shentrypoint preserved.nextcloud-docker-web:mainimage forweb..env.exampletoNEXTCLOUD_VERSION=stable-fpm, following the existing reviewed image promotion logic. The approved inventory currently has major 35 as its newest entry; no Compose or test logic hardcodes a Nextcloud major.pull, and deployment without--build.Regression tests
tests/compose-images.batsuses onlydocker compose configandjq(no image pulls, no real containers, no dependency on the continued existence of a particular version tag). It checks the standard and Garage S3 variants for:stable-fpmas the fallback when the version is unset or empty;appandcron;web:mainimage, the cron entrypoint and absence ofbuildin all three services.The example environment selecting
stable-fpmis also tested. An additional dry-run contract test verifies that maintainer builds use the reviewed upstream base and preserve shell-variable expansion without running Docker. These tests run in the existingmake test-ci-scriptsjob.Historical 33/34/35 fixtures in other regression suites and the supported-version inventory are intentionally unchanged. A maintained major being older than the newest does not make it invalid.
Operational considerations
stable-fpmis a moving tag. It is currently promoted from the newest reviewed supported major byscripts/publish-images.sh. When Nextcloud 36 or a later major is approved, the alias can advance; unattended pulls/recreates can therefore require an upgrade or migration. Production deployments should setNEXTCLOUD_VERSION=<supported-major>-fpm(or an immutable digest) and plan major upgrades explicitly.Makefilemaintainer targets (make test-current-app-image,make scan-images) now select the latest reviewed upstream image and digest from.github/nextcloud-supported.json, independently of the sample deployment.env. This also corrects the previous GNU Make shell-variable escaping in their build arguments ($versionversus$base_image). The base can be overridden withAPP_BASE_IMAGE.No changes to Dockerfiles, published-image workflows, volumes, networks, secrets, application hooks or PostgreSQL versions. Builds for image maintainers remain available.
Related to #47.
Validation